New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation new logger #510

Merged
merged 14 commits into from Feb 6, 2019

Conversation

Projects
None yet
3 participants
@y0sher
Copy link
Collaborator

y0sher commented Feb 3, 2019

Replaced out old logger with a faster and structured logger. changed all log lines that did trouble with the new format. should be much faster. now we can add fields. log.XXXw with log.String/Int/Bool as arguments. json logging is now easy and is a matter of switching a bool.

Show resolved Hide resolved log/log.go Outdated
Show resolved Hide resolved log/log.go Outdated

@y0sher y0sher force-pushed the automation_new_logger branch from aa94cf4 to 7ccf20e Feb 5, 2019

@y0sher y0sher referenced this pull request Feb 5, 2019

Open

Change all logs to formatted or structured messages. #518

0 of 4 tasks complete
Show resolved Hide resolved log/log.go Outdated
@@ -378,7 +381,7 @@ func (s *swarm) processMessage(ime net.IncomingMessageEvent) {

err := s.onRemoteClientMessage(ime)
if err != nil {
s.lNode.Errorf("Err reading message from %v, closing connection err=%v", ime.Conn.RemotePublicKey(), err)
s.lNode.Error("Err reading message from %v, closing connection err=%v", ime.Conn.RemotePublicKey(), err)

This comment has been minimized.

@antonlerner

antonlerner Feb 5, 2019

Collaborator

can we add support for Errorf in the new solution?

This comment has been minimized.

@y0sher

y0sher Feb 5, 2019

Author Collaborator

in the new solution Error works like Errorf. it was like this in last version. we rarely used Errorf

y0sher added some commits Feb 5, 2019

It's been delt with

@y0sher y0sher merged commit 3ae6458 into develop Feb 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment