Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation new logger #510

Merged
merged 14 commits into from Feb 6, 2019
Merged

Automation new logger #510

merged 14 commits into from Feb 6, 2019

Conversation

y0sher
Copy link
Contributor

@y0sher y0sher commented Feb 3, 2019

Replaced out old logger with a faster and structured logger. changed all log lines that did trouble with the new format. should be much faster. now we can add fields. log.XXXw with log.String/Int/Bool as arguments. json logging is now easy and is a matter of switching a bool.

zalmen
zalmen previously requested changes Feb 3, 2019
log/log.go Outdated Show resolved Hide resolved
log/log.go Outdated Show resolved Hide resolved
log/log.go Outdated Show resolved Hide resolved
@@ -378,7 +381,7 @@ func (s *swarm) processMessage(ime net.IncomingMessageEvent) {

err := s.onRemoteClientMessage(ime)
if err != nil {
s.lNode.Errorf("Err reading message from %v, closing connection err=%v", ime.Conn.RemotePublicKey(), err)
s.lNode.Error("Err reading message from %v, closing connection err=%v", ime.Conn.RemotePublicKey(), err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add support for Errorf in the new solution?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the new solution Error works like Errorf. it was like this in last version. we rarely used Errorf

@antonlerner antonlerner dismissed zalmen’s stale review February 6, 2019 09:22

It's been delt with

@y0sher y0sher merged commit 3ae6458 into develop Feb 6, 2019
@y0sher y0sher deleted the automation_new_logger branch June 25, 2019 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants