Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ms1 fixes #577

Merged
merged 23 commits into from Feb 25, 2019
Merged

Ms1 fixes #577

merged 23 commits into from Feb 25, 2019

Conversation

@almogdepaz
Copy link
Contributor

@almogdepaz almogdepaz commented Feb 21, 2019

No description provided.

log.Info("No blocks for consensus on layer %v", id)
blocks, err := h.obp.GetUnverifiedLayerBlocks(h.lastLayer)
if err != nil {
log.Info("No blocks for consensus on layer %v %v", id, err)

This comment has been minimized.

@zalmen

zalmen Feb 24, 2019
Contributor

Why Info? Can it occur in a non-faulty scenario?

This comment has been minimized.

@almogdepaz

almogdepaz Feb 24, 2019
Author Contributor

legacy code...

}

//go ll.onTick()

This comment has been minimized.

@zalmen

zalmen Feb 24, 2019
Contributor

remove?

case layer := <-s.clock:
atomic.StoreUint32(&s.currentLayer, uint32(layer))
s.Info("sync got tick for layer %v", layer)
go foo()

This comment has been minimized.

@zalmen

zalmen Feb 24, 2019
Contributor

Just to make sure I understand - this is where layers are pushed to the Tortoise, right?
If so, why do you wait till the beginning of the layer in order to push the previous layer to the tortoise? You can do that after a minute (or less) from the beginning of the previous layer when all the honest blocks had arrived.
Another "just to make sure" - this doesn't handle late blocks, right? In the current state of the code late blocks will be ignored?

This comment has been minimized.

@almogdepaz

almogdepaz Feb 24, 2019
Author Contributor

you got it right, late block handling will be add with #565
and the concurrent handling will also be a separate pr

@zalmen
zalmen approved these changes Feb 25, 2019
@almogdepaz almogdepaz merged commit c4d6867 into develop Feb 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@almogdepaz almogdepaz deleted the ms1_fixes branch Feb 25, 2019
beckmani added a commit that referenced this pull request Mar 6, 2019
* remove panics, better logs
* integrate sync into app
* send layer clock to mesh
* name change
* use layerTimer as syncTrigger
* fix sync test
* add state root print for flaky test
* fix test change to 10 instances
* fix concurrent layer handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants