Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2p ping #585

Merged
merged 10 commits into from Feb 27, 2019
Merged

P2p ping #585

merged 10 commits into from Feb 27, 2019

Conversation

@y0sher
Copy link
Contributor

@y0sher y0sher commented Feb 27, 2019

No description provided.

@y0sher y0sher requested review from zalmen and antonlerner Feb 27, 2019
return response, nil
}
for _, f := range p.pingCallbacks {
if err := f(req); err != nil {

This comment has been minimized.

@antonlerner

antonlerner Feb 27, 2019
Member

When a callback fails, should we not process al other callbacks? also note that this is done without paralelization and a callback might block execution of other cllbacks

This comment has been minimized.

@y0sher

y0sher Feb 27, 2019
Author Contributor

its actually like this by design.
its a base for #586. we want to make some blocking checks before replying

This comment has been minimized.

@y0sher

y0sher Feb 27, 2019
Author Contributor

ill add a note

Copy link
Member

@antonlerner antonlerner left a comment

Please run with --race to make sure there are no races

p2p/dht/dht.go Outdated Show resolved Hide resolved
@y0sher y0sher force-pushed the p2p_ping branch from 77a5c2b to 1ff527a Feb 27, 2019
@y0sher y0sher merged commit b9f788a into develop Feb 27, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
beckmani added a commit that referenced this pull request Mar 6, 2019
* new ping protocol that uses `MessageServer`
* remove sim methods we had to use when there was no ping
* use random key from second try in bootstrap, refactor loop
* add ping to dht, remove places covered for ping
* minor suite changes, added a really small suite
* swarm: 1.remove from dht on closed connection 2.only do local lookups on sendmessage
* fixed dht test
@y0sher y0sher deleted the p2p_ping branch Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants