added reward application before layer is processed by tortoise #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almogdepaz
reviewed
Mar 5, 2019
config/config.go
Outdated
| @@ -42,6 +43,7 @@ type Config struct { | |||
| HARE hareConfig.Config `mapstructure:"hare"` | |||
| TIME timeConfig.TimeConfig `mapstructure:"time"` | |||
| GAS state.GasParams `mapstructure:"gas"` | |||
| REWARD mesh.RewardParams | |||
There was a problem hiding this comment.
if gas and reward are basically config's it would be nice to align the naming
almogdepaz
reviewed
Mar 5, 2019
mesh/mesh.go
Outdated
| @@ -92,6 +94,12 @@ func (m *Mesh) SetLatestLayer(idx uint32) { | |||
|
|
|||
| func (m *Mesh) ValidateLayer(layer *Layer) { | |||
| m.Info("Validate layer %d", layer.Index()) | |||
|
|
|||
| //todo: with the introduction of rewards we need to refactor this loop out of since it now serves multiple purposes | |||
There was a problem hiding this comment.
diden't understand what still needs to be done here
antonlerner
force-pushed
the
reward_integration
branch
from
39d1987
to
f052322
Compare
almogdepaz
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.