Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added reward application before layer is processed by tortoise #617

merged 2 commits into from Mar 6, 2019


Copy link

@antonlerner antonlerner commented Mar 5, 2019

No description provided.

@@ -42,6 +43,7 @@ type Config struct {
HARE hareConfig.Config `mapstructure:"hare"`
TIME timeConfig.TimeConfig `mapstructure:"time"`
GAS state.GasParams `mapstructure:"gas"`
REWARD mesh.RewardParams

This comment has been minimized.


almogdepaz Mar 5, 2019

if gas and reward are basically config's it would be nice to align the naming

@@ -92,6 +94,12 @@ func (m *Mesh) SetLatestLayer(idx uint32) {

func (m *Mesh) ValidateLayer(layer *Layer) {
m.Info("Validate layer %d", layer.Index())

//todo: with the introduction of rewards we need to refactor this loop out of since it now serves multiple purposes

This comment has been minimized.


almogdepaz Mar 5, 2019

diden't understand what still needs to be done here

@antonlerner antonlerner force-pushed the reward_integration branch from 39d1987 to f052322 Mar 6, 2019
@antonlerner antonlerner merged commit ae9116f into develop Mar 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
@y0sher y0sher deleted the reward_integration branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants