Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker, makefile, p2p main #655

Merged
merged 3 commits into from Mar 14, 2019
Merged

docker, makefile, p2p main #655

merged 3 commits into from Mar 14, 2019

Conversation

@y0sher
Copy link
Contributor

@y0sher y0sher commented Mar 12, 2019

No description provided.

@y0sher y0sher requested a review from gavraz Mar 12, 2019
endif
.PHONY: build

hare:
cd cmd/hare ; go build -o $(CURR_DIR)/go-hare; cd ..
ifeq ($(OS),Windows_NT)

This comment has been minimized.

@gavraz

gavraz Mar 13, 2019
Contributor

I think we should create a func build_path(NAME) and not repeat this if else when not necessary.

This comment has been minimized.

@antonlerner

antonlerner Mar 13, 2019
Member

or even use the if once to assign the correct path to $(BIN_DIR)

This comment has been minimized.

@gavraz

gavraz Mar 13, 2019
Contributor

Yeah, but you still need to push the name in the string (see the .exe for example).

cmdp.AddCommands(Cmd)
}

type P2PApp struct {

This comment has been minimized.

@gavraz

gavraz Mar 13, 2019
Contributor

Why not remove the BaseApp? Then the Hare can be composed of P2PApp. Same goes for the SpacemeshApp.

This comment has been minimized.

@y0sher

y0sher Mar 13, 2019
Author Contributor

If we'll do that it will be a problem compiling the p2p app as a standalone

This comment has been minimized.

@y0sher

y0sher Mar 13, 2019
Author Contributor

Because it has to have a main to do so. and if we'll do it we won't be able to use it embedded in other structs.

Copy link
Contributor

@gavraz gavraz left a comment

  1. Fix makefile (extract func)
  2. Remove p2p dockerfile
@y0sher y0sher force-pushed the p2p_docker_makefile branch from 8c5b800 to fb8d86c Mar 14, 2019
@y0sher y0sher requested a review from gavraz Mar 14, 2019
@y0sher
Copy link
Contributor Author

@y0sher y0sher commented Mar 14, 2019

opened #660 about reducing code duplication in the Makefile

@gavraz
gavraz approved these changes Mar 14, 2019
@y0sher y0sher merged commit 402be88 into develop Mar 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@y0sher y0sher deleted the p2p_docker_makefile branch Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants