Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store eligibility proof in block and validate it #792

merged 4 commits into from Apr 10, 2019


None yet
3 participants
Copy link

noamnelke commented Apr 7, 2019

No description provided.

@noamnelke noamnelke requested a review from antonlerner Apr 7, 2019

@@ -374,19 +374,20 @@ func (app *SpacemeshApp) Start(cmd *cobra.Command, args []string) {

app.unregisterOracle = func() { oracleClient.Unregister(true, pub.String()) }

//bo := oracle.NewBlockOracleFromClient(oracleClient, int(app.Config.CONSENSUS.NodesPerLayer))
nodesPerLayer := app.Config.CONSENSUS.NodesPerLayer
layersPerEpoch := app.Config.CONSENSUS.LayersPerEpoch
activationDb := &activation.ActivationDb{} // TODO: initialize properly

This comment has been minimized.

Copy link

almogdepaz Apr 8, 2019


app.Config.CONSENSUS.NodesPerLayer is the size of the layer ?
if so we already have a flag for that

This comment has been minimized.

Copy link

noamnelke Apr 8, 2019

Author Contributor

As Shaggy would put it: it wasn't me...


This comment has been minimized.

Copy link

almogdepaz Apr 8, 2019


my only point was that this sort of thing can take up lots of time if configured wrong,
we have enough args as it is we don't need to add keep duplicates.
i opened #798.
anyway that commit is referencing dolev strong its old and not used

@noamnelke noamnelke merged commit 450371c into develop Apr 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.