Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store eligibility proof in block and validate it #792

Merged
merged 4 commits into from
Apr 10, 2019

Conversation

noamnelke
Copy link
Member

No description provided.

@@ -374,19 +374,20 @@ func (app *SpacemeshApp) Start(cmd *cobra.Command, args []string) {

app.unregisterOracle = func() { oracleClient.Unregister(true, pub.String()) }

//bo := oracle.NewBlockOracleFromClient(oracleClient, int(app.Config.CONSENSUS.NodesPerLayer))
nodesPerLayer := app.Config.CONSENSUS.NodesPerLayer
layersPerEpoch := app.Config.CONSENSUS.LayersPerEpoch
activationDb := &activation.ActivationDb{} // TODO: initialize properly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app.Config.CONSENSUS.NodesPerLayer is the size of the layer ?
if so we already have a flag for that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Shaggy would put it: it wasn't me...
fb3af28#diff-9341369a460f3f5c5336176dfbca5fbbR10

shaggy

Copy link
Contributor

@almogdepaz almogdepaz Apr 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my only point was that this sort of thing can take up lots of time if configured wrong,
we have enough args as it is we don't need to add keep duplicates.
i opened #798.
anyway that commit is referencing dolev strong its old and not used

@noamnelke noamnelke merged commit 450371c into develop Apr 10, 2019
@noamnelke noamnelke deleted the store_eligibility_proof_in_block branch June 30, 2019 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants