Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hare sig #795

Merged
merged 5 commits into from Apr 17, 2019
Merged

Hare sig #795

merged 5 commits into from Apr 17, 2019

Conversation

@gavraz
Copy link
Contributor

@gavraz gavraz commented Apr 8, 2019

  • Added new signer verifier
  • Removed pub key from hare proto
  • Fully replaced hare sig with public extraction
@gavraz gavraz requested review from zalmen, y0sher and antonlerner Apr 8, 2019
cmd/node/node.go Outdated Show resolved Hide resolved
cmd/node/node.go Outdated Show resolved Hide resolved
cmd/node/node.go Outdated Show resolved Hide resolved
cmd/node/node.go Outdated Show resolved Hide resolved
cmd/node/node.go Outdated Show resolved Hide resolved
cmd/node/node.go Outdated Show resolved Hide resolved
cmd/node/node.go Outdated Show resolved Hide resolved
hare/algorithm.go Outdated Show resolved Hide resolved
hare/algorithm.go Outdated Show resolved Hide resolved
signing/verifier.go Outdated Show resolved Hide resolved
signing/verifier.go Outdated Show resolved Hide resolved
signing/verifier.go Outdated Show resolved Hide resolved
if len(buff) < 32 {
return nil, errors.New("buffer too small")
}
return &EdSigner{privKey: buff, pubKey: buff[:32]}, nil

This comment has been minimized.

@zalmen

zalmen Apr 14, 2019
Contributor

Ask @barakshani if there is any way to validate that the private key matches the public key

This comment has been minimized.

@barakshani

barakshani Apr 14, 2019
Contributor

I am not sure what is the context here, but if you hold the private key, you can always recompute the public key from it

This comment has been minimized.

@gavraz

gavraz Apr 16, 2019
Author Contributor

I sign and verify.

This comment has been minimized.

@zalmen

zalmen Apr 16, 2019
Contributor

@barakshani 's solution is more elegant and efficient

signing/signer.go Show resolved Hide resolved
signing/signer.go Outdated Show resolved Hide resolved
signing/signer.go Outdated Show resolved Hide resolved
signing/verifier.go Outdated Show resolved Hide resolved
@gavraz gavraz force-pushed the hare_sig branch from 71af25b to 4cfbec0 Apr 15, 2019
cmd/node/node.go Outdated Show resolved Hide resolved
cmd/node/node.go Outdated Show resolved Hide resolved
cmd/node/node.go Outdated Show resolved Hide resolved
cmd/node/node.go Show resolved Hide resolved
cmd/node/node.go Outdated Show resolved Hide resolved
hare/algorithm.go Outdated Show resolved Hide resolved
signing/signer.go Show resolved Hide resolved
@gavraz gavraz force-pushed the hare_sig branch from 1904938 to 87fa090 Apr 16, 2019
@zalmen
zalmen approved these changes Apr 16, 2019
@gavraz gavraz merged commit 6325434 into develop Apr 17, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@y0sher y0sher deleted the hare_sig branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants