Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full build on branch #832

Merged
merged 12 commits into from Apr 28, 2019
Merged

Full build on branch #832

merged 12 commits into from Apr 28, 2019

Conversation

@beckmani
Copy link
Contributor

@beckmani beckmani commented Apr 17, 2019

Enable to run all tests from developer computer.

  1. Build the code
  2. Push image to docker hub
  3. Run tests with image from(2) automatic
@beckmani beckmani requested review from y0sher and gavraz Apr 17, 2019
def set_docker_images():
docker_image = os.getenv('CLIENT_DOCKER_IMAGE', '')
if docker_image:
print("Set docker images to: {0}".format(docker_image))

This comment has been minimized.

@antonlerner

antonlerner Apr 28, 2019
Member

where is this printed? maybe we should store it in a log file in case we cant see the print?

This comment has been minimized.

@beckmani

beckmani Apr 28, 2019
Author Contributor

Currently we don't have log for tests other than stdout

@beckmani beckmani merged commit 2895e44 into develop Apr 28, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@beckmani beckmani deleted the full-build-on-branch branch Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants