Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hare vrf eligibility #834

Merged
merged 11 commits into from Apr 18, 2019
Merged

Hare vrf eligibility #834

merged 11 commits into from Apr 18, 2019

Conversation

@gavraz
Copy link
Contributor

@gavraz gavraz commented Apr 18, 2019

  • (Anton) added identity store
  • Added hare vrf oracle and hare beacon
@gavraz gavraz requested review from antonlerner, zalmen and barakshani Apr 18, 2019
hare/eligibility/oracle.go Outdated Show resolved Hide resolved
hare/eligibility/oracle.go Outdated Show resolved Hide resolved
hare/eligibility/oracle.go Outdated Show resolved Hide resolved
activation/atxdb.go Outdated Show resolved Hide resolved
@@ -294,7 +294,12 @@ func (app *SpacemeshApp) initServices(nodeID types.NodeId, swarm service.Service
}

//todo: put in config
atxdb := activation.NewActivationDb(atxdbstore, mdb, 1000)
iddbstore, err := database.NewLDBDatabase(dbStorepath+"ids", 0, 0)

This comment has been minimized.

@antonlerner

antonlerner Apr 18, 2019
Member

we've already fixed this bug in our branch, but for better UT the DB should be received from whom ever calls this function, in case of UT you dont need persistent DB like LDB

hare/eligibility/oracle.go Outdated Show resolved Hide resolved
hare/eligibility/oracle.go Outdated Show resolved Hide resolved
@gavraz gavraz force-pushed the hare_vrf_eligibility branch from 921e0a7 to cb5e9e1 Apr 18, 2019
@gavraz gavraz merged commit c50f602 into develop Apr 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@y0sher y0sher deleted the hare_vrf_eligibility branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants