Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atx automation tests #875

Merged
merged 16 commits into from May 6, 2019

Conversation

Projects
None yet
3 participants
@antonlerner
Copy link
Member

commented May 5, 2019

No description provided.

@beckmani beckmani referenced this pull request May 5, 2019

Closed

run poet server in setup #866

antonlerner added some commits May 5, 2019

@@ -105,12 +105,12 @@ func (validator *syntaxContextValidator) SyntacticallyValidateMessage(m *Msg) bo
}

if m.InnerMsg.Values == nil {
validator.Warning("Syntax validation failed: Values is nil in msg: %v", m)
validator.Warning("Syntax validation failed: Values is nil in msg: %v", m.String())

This comment has been minimized.

Copy link
@gavraz

gavraz May 5, 2019

Contributor

Ok, though I am wondering if we better have an err return value and than it can be printed in the most upper level for which it is relevant. It will also uncouple many other inner analyzers from the log object. What do you think?

This comment has been minimized.

Copy link
@antonlerner

antonlerner May 6, 2019

Author Member

error should be returned only when an error occurs and not to describe a reason for some output

atxdb := activation.NewActivationDb(atxdbstore, idStore, mdb, uint64(app.Config.CONSENSUS.LayersPerEpoch), validator, lg.WithName("atxDb"))
beaconProvider := &oracle.EpochBeaconProvider{}
blockOracle := oracle.NewMinerBlockOracle(int32(numOfInstances), layersPerEpoch, atxdb, beaconProvider, vrfSigner, nodeID, lg.WithName("blockOracle"))
blockValidator := oracle.NewBlockEligibilityValidator(int32(numOfInstances), layersPerEpoch, atxdb, beaconProvider, crypto.ValidateVRF, lg.WithName("blkElgValidator"))
blockOracle := oracle.NewMinerBlockOracle(int32(layerSize), uint16(layersPerEpoch), atxdb, beaconProvider, vrfSigner, nodeID, lg.WithName("blockOracle"))

This comment has been minimized.

Copy link
@gavraz

gavraz May 5, 2019

Contributor

why not uint32?

@@ -444,22 +432,29 @@ func (app *SpacemeshApp) Start(cmd *cobra.Command, args []string) {
log.Panic("Could not retrieve identity err=%v", err)
}

vrfPublicKey, vrfPrivateKey, err := crypto.GenerateVRFKeys()

This comment has been minimized.

Copy link
@gavraz

gavraz May 5, 2019

Contributor

That is a mock? if so add a comment. If not what is it? we still haven't integrated bls...

This comment has been minimized.

Copy link
@antonlerner

antonlerner May 6, 2019

Author Member

this is not a mock. it uses some signature scheme

@gavraz

gavraz approved these changes May 5, 2019

@antonlerner antonlerner merged commit eeda1c1 into develop May 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.