Atx automation tests #875
Merged
Atx automation tests #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavraz
reviewed
May 5, 2019
| @@ -105,12 +105,12 @@ func (validator *syntaxContextValidator) SyntacticallyValidateMessage(m *Msg) bo | |||
| } | |||
|
|
|||
| if m.InnerMsg.Values == nil { | |||
| validator.Warning("Syntax validation failed: Values is nil in msg: %v", m) | |||
| validator.Warning("Syntax validation failed: Values is nil in msg: %v", m.String()) | |||
There was a problem hiding this comment.
Ok, though I am wondering if we better have an err return value and than it can be printed in the most upper level for which it is relevant. It will also uncouple many other inner analyzers from the log object. What do you think?
There was a problem hiding this comment.
error should be returned only when an error occurs and not to describe a reason for some output
gavraz
reviewed
May 5, 2019
cmd/node/node.go
Outdated
| atxdb := activation.NewActivationDb(atxdbstore, idStore, mdb, uint64(app.Config.CONSENSUS.LayersPerEpoch), validator, lg.WithName("atxDb")) | ||
| beaconProvider := &oracle.EpochBeaconProvider{} | ||
| blockOracle := oracle.NewMinerBlockOracle(int32(numOfInstances), layersPerEpoch, atxdb, beaconProvider, vrfSigner, nodeID, lg.WithName("blockOracle")) | ||
| blockValidator := oracle.NewBlockEligibilityValidator(int32(numOfInstances), layersPerEpoch, atxdb, beaconProvider, crypto.ValidateVRF, lg.WithName("blkElgValidator")) | ||
| blockOracle := oracle.NewMinerBlockOracle(int32(layerSize), uint16(layersPerEpoch), atxdb, beaconProvider, vrfSigner, nodeID, lg.WithName("blockOracle")) |
gavraz
reviewed
May 5, 2019
| @@ -444,22 +432,29 @@ func (app *SpacemeshApp) Start(cmd *cobra.Command, args []string) { | |||
| log.Panic("Could not retrieve identity err=%v", err) | |||
| } | |||
|
|
|||
| vrfPublicKey, vrfPrivateKey, err := crypto.GenerateVRFKeys() | |||
There was a problem hiding this comment.
That is a mock? if so add a comment. If not what is it? we still haven't integrated bls...
There was a problem hiding this comment.
this is not a mock. it uses some signature scheme
gavraz
approved these changes
May 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.