Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for add new client #888

Merged
merged 12 commits into from
May 15, 2019
Merged

Add test for add new client #888

merged 12 commits into from
May 15, 2019

Conversation

beckmani
Copy link
Contributor

Added new fixture: add_client
Added new test: Test that new client finishes bootstrap

@beckmani beckmani requested a review from antonlerner May 12, 2019 14:41
def add_client(request, setup_oracle, setup_poet, setup_bootstrap):

def _add_single_client():
bs_info = setup_bootstrap.pods[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if no bootstrap this will fail, add a message for that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Added check before.

tests/test_bs.py Outdated
cimage=testconfig['client']['image'],
centry=[testconfig['client']['command']])

cspec.append_args(bootnodes="{0}:{1}/{2}".format(bs_info['pod_ip'], '7513', bs_info['key']),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move port to constant variable

tests/test_bs.py Outdated

cspec.append_args(bootnodes="{0}:{1}/{2}".format(bs_info['pod_ip'], '7513', bs_info['key']),
oracle_server='http://{0}:3030'.format(setup_oracle),
poet_server='{0}:50002'.format(setup_poet),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

tests/test_bs.py Outdated

k8s_api = client.CoreV1Api()
resp = k8s_api.create_namespaced_pod(namespace=name_space, body=dep)
wait_for_pod_to_be_ready(resp.metadata._name, name_space, time_out=testconfig['deployment_ready_time_out'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should have a different timeout for a single node than of a larger deployment

- name: client
image: spacemeshos/go-spacemesh:develop
imagePullPolicy: Always
args: ['--randcon', '3', '--bootstrap', '--test-mode', '--oracle_server', 'http://10.12.3.14:3030', '--grpc-server', '--json-server', '--bootnodes', '10.36.1.12:7513/26hRBJqMJPUnKgJ9VR6g3kH6aCQhZ9shBvhn3bEHDvRyv']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be parameterised?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. we override it later

body=client.V1DeleteOptions(propagation_policy='Foreground',
grace_period_seconds=5))
except ApiException as e:
if e.status == 404:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about other errors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error may result from timing. (The pod may be delete before we get here)
Other error should not be ignored

try:
resp = client.CoreV1Api().read_namespaced_pod(name=pod_name, namespace=name_space)
except ApiException as e:
if e.status == 404:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about other errors



@pytest.fixture()
def add_client(request, setup_oracle, setup_poet, setup_bootstrap, setup_clients):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment about this not being a functional fixture and shouldn't be used in our tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

dep = container_specs.update_deployment(dep)

k8s_api = client.CoreV1Api()
resp = k8s_api.create_namespaced_pod(namespace=name_space, body=dep)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if resp is error should we wait for pod to be ready?

def wait_for_pod_to_be_ready(pod_name, name_space, time_out=None):
total_sleep_time = 0
while True:
resp = client.CoreV1Api().read_namespaced_pod(name=pod_name, namespace=name_space)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this return error? what should happen if so?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. I havn't met an error here.
If we see that there are errors here we will handle them in the future

total_sleep_time = 0
while True:
try:
resp = client.CoreV1Api().read_namespaced_pod(name=pod_name, namespace=name_space)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this return error? what should happen if so?

@beckmani beckmani merged commit c34887e into develop May 15, 2019
@y0sher y0sher deleted the add-pod-to-setup branch June 25, 2019 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Accounts
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants