Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genesis nonce scheme #104

Closed
7 tasks done
lrettig opened this issue Dec 18, 2021 · 3 comments
Closed
7 tasks done

Genesis nonce scheme #104

lrettig opened this issue Dec 18, 2021 · 3 comments

Comments

@lrettig
Copy link
Member

lrettig commented Dec 18, 2021

Under account unification, each principal account is free to implement its own nonce scheme. For genesis, we need to design and implement one standard, recommended nonce scheme that will be included in the genesis smart contracts.

See https://community.spacemesh.io/t/nonce-schemes-and-account-unification/202

Other links to read:

SMIP: spacemeshos/SMIPS#79

Related: #20

  • Review forum thread
  • Update tx structure doc
  • Review tx structure doc with @noamnelke and @dshulyak
  • Decide how/where tx sorting happens (outside VM, as cmax | ~noncemask)
  • Decide how/where nonce checking (validity predicate) happens (inside verify())
  • Decide how/where nonce update happens (inside VM, NonceUpdate template method)
  • Dev task breakdown (Genesis nonce scheme #104)
@lrettig lrettig self-assigned this Dec 18, 2021
@lrettig lrettig added this to In progress in Spacemesh 0.3 Release Dec 18, 2021
@noamnelke noamnelke changed the title Finalize genesis nonce scheme Genesis nonce scheme Feb 21, 2022
@noamnelke noamnelke self-assigned this Mar 9, 2022
@lrettig
Copy link
Member Author

lrettig commented Jun 15, 2022

Noam described this in tx structure doc

@lrettig
Copy link
Member Author

lrettig commented Jul 15, 2022

Finished reviewing forum thread, and updated tx structure doc. Next step: discuss with Noam and Dima, make final decisions (see checklist above), then write dev task breakdown.

@lrettig lrettig changed the title Genesis nonce scheme Design genesis nonce scheme Jul 15, 2022
@lrettig lrettig added the design label Jul 15, 2022
@lrettig lrettig changed the title Design genesis nonce scheme Finalize design: genesis nonce scheme Jul 15, 2022
@lrettig
Copy link
Member Author

lrettig commented Jul 28, 2022

Discussed this with @noamnelke and @selfdual-brain today. We decided to stick with a simple "int nonces with gaps" scheme: see #150 for the straightforward proposed design and dev tasks breakdown. We'll continue to discuss more sophisticated, generalized nonce schemes for the future.

@lrettig lrettig closed this as completed Jul 28, 2022
@selfdual-brain selfdual-brain changed the title Finalize design: genesis nonce scheme Genesis nonce scheme Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Green light from dev
Status: Done
Development

No branches or pull requests

2 participants