Configurable tree file-based layers buffer size #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
approved these changes
Jan 26, 2023
Comment on lines
+99
to
+101
| if treeCfg.MinMemoryLayer < LowestMerkleMinMemoryLayer { | ||
| treeCfg.MinMemoryLayer = LowestMerkleMinMemoryLayer | ||
| } |
There was a problem hiding this comment.
Is this behaviour documented somewhere?
There was a problem hiding this comment.
I don't think it is. It just means that at least 1 tree layer (the base layer) will be stored on a disk. Please note, that I just moved this condition from service.go (there is no behaviour change).
pigmej
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new configuration flags:
--lpsto configure the estimated leaves per second (it's different per platform)It's important for the poet service to estimate the size of proof tree upfront.
--tree-file-bufferto configure the buffer size for file-base (bottom) layers of the proof tree.