Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if Submit Request contains Pubkey #283

Merged
merged 3 commits into from
Apr 12, 2023

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Apr 12, 2023

Instead of panicing on missing public key in a Submit request, return an error.

@fasmat fasmat requested a review from poszu April 12, 2023 15:48
@fasmat fasmat self-assigned this Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #283 (fc26806) into develop (5e5ec33) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           develop    #283   +/-   ##
=======================================
  Coverage     69.7%   69.7%           
=======================================
  Files           18      18           
  Lines         1513    1516    +3     
=======================================
+ Hits          1055    1058    +3     
  Misses         348     348           
  Partials       110     110           
Impacted Files Coverage Δ
rpc/rpcserver.go 78.3% <100.0%> (+0.8%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pigmej pigmej added this pull request to the merge queue Apr 12, 2023
Merged via the queue into develop with commit eea3851 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants