Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New poet #49

Merged
merged 18 commits into from
May 8, 2019
Merged

New poet #49

merged 18 commits into from
May 8, 2019

Conversation

noamnelke
Copy link
Member

@noamnelke noamnelke commented May 1, 2019 •
edited by moshababo
Loading

Still a draft. Todo:

  • Connect to outside (grpc)
  • Remove old code (incl. some renaming and other cleanup)
  • More tests and benchmarks
  • After merging get parked nodes merkle-tree#7 - point dependency to develop (currently points to working branch)

Closing #37.

@noamnelke noamnelke requested a review from zalmen May 1, 2019 12:58
zalmen
zalmen reviewed May 2, 2019
View reviewed changes
prover/newprover.go Outdated Show resolved Hide resolved
prover/newprover.go Outdated Show resolved Hide resolved
prover/newprover.go Outdated Show resolved Hide resolved
verifier/newverifier.go Outdated Show resolved Hide resolved
verifier/newverifier.go Outdated Show resolved Hide resolved
verifier/newverifier.go Outdated Show resolved Hide resolved
@zalmen zalmen marked this pull request as ready for review May 7, 2019 10:13
zalmen
zalmen suggested changes May 7, 2019
View reviewed changes
prover/diskreadwriter.go Outdated Show resolved Hide resolved
prover/diskreadwriter.go Outdated Show resolved Hide resolved
prover/readwritermetafactory.go Show resolved Hide resolved
prover/readwritermetafactory.go Outdated Show resolved Hide resolved
@noamnelke noamnelke requested a review from zalmen May 7, 2019 21:20
@noamnelke noamnelke merged commit f56ec5e into develop May 8, 2019
@moshababo moshababo mentioned this pull request May 8, 2019
Closed
@fasmat fasmat deleted the new_poet branch November 29, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zalmen zalmen zalmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noamnelke @zalmen