Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local node setup logic #59

Merged
merged 7 commits into from Mar 28, 2019

Conversation

Projects
None yet
2 participants
@yhaspel
Copy link
Collaborator

yhaspel commented Mar 27, 2019

No description provided.

@yhaspel yhaspel requested a review from IlyaVi Mar 27, 2019

Show resolved Hide resolved desktop/main.dev.js Outdated

admin added some commits Mar 27, 2019

admin admin
admin admin

class DiskStorageManager {
static getDriveList = ({ event }: { event: any }) => {
drivelist.list((error, drives) => {

This comment has been minimized.

Copy link
@IlyaVi

IlyaVi Mar 27, 2019

Collaborator

the docs of the library states that main usage is through async function

const drivelist = require('drivelist');

const drives = await drivelist.list();
console.log(drives);

This comment has been minimized.

Copy link
@yhaspel

yhaspel Mar 27, 2019

Author Collaborator

There's an issue with version 8+ of this package. Version 6 is installed works as coded.

This comment has been minimized.

Copy link
@yhaspel

yhaspel Mar 27, 2019

Author Collaborator

The issue is with electron and version 8 of this package.

Show resolved Hide resolved app/redux/localNode/reducer.js Outdated

admin added some commits Mar 27, 2019

admin admin
admin admin
admin admin

@yhaspel yhaspel merged commit 945417c into develop Mar 28, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@yhaspel yhaspel deleted the local-node-setup-logic branch Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.