Local node setup logic #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaVi
reviewed
Mar 27, 2019
IlyaVi
reviewed
Mar 27, 2019
IlyaVi
reviewed
Mar 27, 2019
IlyaVi
reviewed
Mar 27, 2019
IlyaVi
reviewed
Mar 27, 2019
IlyaVi
reviewed
Mar 27, 2019
IlyaVi
reviewed
Mar 27, 2019
|
|
||
| class DiskStorageManager { | ||
| static getDriveList = ({ event }: { event: any }) => { | ||
| drivelist.list((error, drives) => { |
There was a problem hiding this comment.
the docs of the library states that main usage is through async function
const drivelist = require('drivelist');
const drives = await drivelist.list();
console.log(drives);
There was a problem hiding this comment.
There's an issue with version 8+ of this package. Version 6 is installed works as coded.
There was a problem hiding this comment.
The issue is with electron and version 8 of this package.
IlyaVi
reviewed
Mar 27, 2019
IlyaVi
reviewed
Mar 27, 2019
IlyaVi
reviewed
Mar 27, 2019
IlyaVi
reviewed
Mar 27, 2019
added 3 commits
March 27, 2019 17:29
…al node setup render
…al node setup render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.