Feat: auto start node before launch

[maparr]

It closes #906

[github-actions]

Compiled Binaries

• Windows: https://storage.googleapis.com/smapp/pr-08280df94182c2ac4f69d68ebf263f6e1b053f45/Spacemesh%20Setup%200.2.6-pr.945.exe
• macOS: https://storage.googleapis.com/smapp/pr-08280df94182c2ac4f69d68ebf263f6e1b053f45/Spacemesh-0.2.6-pr.945.dmg
• Linux: https://storage.googleapis.com/smapp/pr-08280df94182c2ac4f69d68ebf263f6e1b053f45/spacemesh_app_0.2.6-pr.945_amd64.deb

[github-actions]

Compiled Binaries

• Windows: https://storage.googleapis.com/smapp/pr-12068fe02958577deb1c84c829e0c8403097c8b7/Spacemesh%20Setup%200.2.6-pr.945.exe
• macOS: https://storage.googleapis.com/smapp/pr-12068fe02958577deb1c84c829e0c8403097c8b7/Spacemesh-0.2.6-pr.945.dmg
• Linux: https://storage.googleapis.com/smapp/pr-12068fe02958577deb1c84c829e0c8403097c8b7/spacemesh_app_0.2.6-pr.945_amd64.deb

[github-actions]

Compiled Binaries

• Windows: https://storage.googleapis.com/smapp/pr-8ecbd160ef132bc85da07821e740dc91168976b3/Spacemesh%20Setup%200.2.6-pr.945.exe
• macOS: https://storage.googleapis.com/smapp/pr-8ecbd160ef132bc85da07821e740dc91168976b3/Spacemesh-0.2.6-pr.945.dmg
• Linux: https://storage.googleapis.com/smapp/pr-8ecbd160ef132bc85da07821e740dc91168976b3/spacemesh_app_0.2.6-pr.945_amd64.deb

[brusherru]

Are you sure that $currentNetwork works as expected?
Seems it will always have undefined instead of wallet meta, since the input argument is a Tuple [Network[], bool, WalletMeta|undefined]...
Am I miss something?

[maparr]

Are you sure that $currentNetwork works as expected? Seems it will always have undefined instead of wallet meta, since the input argument is a Tuple [Network[], bool, WalletMeta|undefined]... Am I miss something?

yes, tested changes. the current network will be or default network if the start node is on the auto-start step. of when wallet will be unlocked, iif statement waiting wallet unlock. So
combineLatestWith($wallet.pipe(map((w) => w?.meta.netId))) will hit the goal , when wallet will be available. Remote API/ unlock wallet / new wallet working as expected, checked with auto-start and without.

[github-actions]

Compiled Binaries

• Windows: https://storage.googleapis.com/smapp/pr-c36d4055201fba4aba0f1f68bf5b6f78e43af7df/Spacemesh%20Setup%200.2.6-pr.945.exe
• macOS: https://storage.googleapis.com/smapp/pr-c36d4055201fba4aba0f1f68bf5b6f78e43af7df/Spacemesh-0.2.6-pr.945.dmg
• Linux: https://storage.googleapis.com/smapp/pr-c36d4055201fba4aba0f1f68bf5b6f78e43af7df/spacemesh_app_0.2.6-pr.945_amd64.deb

[brusherru]

LGTM

p.s.
But I started thinking, do we really need to run it only on autostart, or on any app start? ;)
It might be a bit confusing. E.G. User uses auto-start and knows that Smapp smeshes for him. But then something went wrong (he closed the app / it crashed / etc) — the User restarts it and, I assume, he will expect the same behavior — just run and forget (no need to unlock).
What do you think?
cc: @oriya @pigmej

[pigmej]

if I'd be the user I'd expect:

1. when I close -> full unlock
2. when app crashes -> to be discussed
3. when I want it to autostart should autostart WITHOUT ulock with big warning about the security problems that it can lead to.

[pigmej]

We can also put it past genesis ;)

[github-actions]

Compiled Binaries

• Windows: https://storage.googleapis.com/smapp/pr-b46e25f6bf305cef5fcb7e92f90f4345563f64b7/Spacemesh%20Setup%200.2.6-pr.945.exe
• macOS: https://storage.googleapis.com/smapp/pr-b46e25f6bf305cef5fcb7e92f90f4345563f64b7/Spacemesh-0.2.6-pr.945.dmg
• Linux: https://storage.googleapis.com/smapp/pr-b46e25f6bf305cef5fcb7e92f90f4345563f64b7/spacemesh_app_0.2.6-pr.945_amd64.deb

[brusherru]

@pigmej

big warning about the security problems that it can lead to

Do you know any? :)

[pigmej]

Permanently unlocked wallet?

[brusherru]

Permanently unlocked wallet?

No-no. The wallet is locked all the time until you type the password.
But you don't need to unlock the wallet just to start the Node and start smeshing — Smesher's coinbase is stored in the node config next to other required settings.
You'll need to unlock the wallet only when you want to send some transactions.

[brusherru]

👍

[pigmej]

OK, then clear to me :) sorry for the confusion ;)

[github-actions]

Compiled Binaries

• Windows: https://storage.googleapis.com/smapp/pr-132ff2311a61bd7e3c2e1cf88588ef4104d8941c/Spacemesh%20Setup%200.2.6-pr.945.exe
• macOS: https://storage.googleapis.com/smapp/pr-132ff2311a61bd7e3c2e1cf88588ef4104d8941c/Spacemesh-0.2.6-pr.945.dmg
• Linux: https://storage.googleapis.com/smapp/pr-132ff2311a61bd7e3c2e1cf88588ef4104d8941c/spacemesh_app_0.2.6-pr.945_amd64.deb

[oriya]

Makes sense!