Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop Notifications #97

Merged
merged 10 commits into from May 30, 2019

Conversation

Projects
None yet
2 participants
@yhaspel
Copy link
Collaborator

commented May 23, 2019

Desktop Notifications initial commit:

  1. User can now select either to quit app or keep it hidden in background
  2. Notifications show only when app is hidden
  3. Notifying on local node setup complete
    1. Local node status still based on stub implementation and not actual status
  4. Clicking on notification opens the app (if app is hidden)
  5. Navigate to local node regardless of page when app was closed (Unless logged out)

Need to implement in next commits:

  1. connect notifications to transactions, update, mining awards (in log) - will need to be implemented when actual node APIs are in place

admin and others added some commits May 23, 2019

@yhaspel yhaspel requested a review from IlyaVi May 26, 2019

@IlyaVi IlyaVi changed the title desktop notification - initial commit Desktop Notifications May 29, 2019

Show resolved Hide resolved desktop/notificationsManager.js Outdated
Show resolved Hide resolved desktop/notificationsManager.js Outdated
Show resolved Hide resolved desktop/eventListners.js Outdated
Show resolved Hide resolved desktop/eventListners.js Outdated
Show resolved Hide resolved app/redux/localNode/reducer.js Outdated
Show resolved Hide resolved desktop/eventListners.js Outdated
admin admin
Show resolved Hide resolved app/vars/ipcConsts.js Outdated
admin admin
@IlyaVi

IlyaVi approved these changes May 30, 2019

@IlyaVi IlyaVi merged commit 566e9b3 into develop May 30, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@IlyaVi IlyaVi deleted the desktop-notifications branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.