Skip to content
This repository was archived by the owner on Aug 14, 2023. It is now read-only.

Transaction Envelope and Context#311

Merged
YaronWittenstein merged 31 commits into
masterfrom
tx-envelope
Jul 22, 2021
Merged

Transaction Envelope and Context#311
YaronWittenstein merged 31 commits into
masterfrom
tx-envelope

Conversation

@YaronWittenstein
Copy link
Copy Markdown
Contributor

@YaronWittenstein YaronWittenstein commented Jul 20, 2021 •
edited
Loading

This PR attempts to be faithful to the AA Transactions & SVM Integration SMIP.
It's a perquisite for starting the integration with go-svm and later with the go-spacemesh.

Closes #253 #244 #309

Changes

  • Added Envelope and Context to svm-types.
  • Started using the term Message when referring to the binary SVM transaction under svm-runtime and svm-runtime-ffi.
  • Implemented encoding for Envelope and Context under svm-codec.
  • Modified the Runtime trait under svm-runtime to use the Envelope and Context.
  • Simplified creation of In-memory Runtime (doesn't require an injected Key-Value anymore).
  • Adapted the tests of svm-runtime according to the above changes.
  • Modified the runtime-ffi API to adapt to the SMIP as well.
  • Renamed previously missed usages of App into Account.

Future Issues:

@YaronWittenstein YaronWittenstein added this to the July 19 Sprint milestone Jul 20, 2021
This was linked to issues Jul 20, 2021
AA: Add Envelope to the API #244
Closed
AA: Add Context to the API #309
Closed
@YaronWittenstein YaronWittenstein added AA Related to the Accounts Abstraction svm v0.3 labels Jul 20, 2021
@YaronWittenstein YaronWittenstein self-assigned this Jul 20, 2021
@YaronWittenstein YaronWittenstein requested a review from neysofu July 20, 2021 06:22
@YaronWittenstein
runtime-ffi: changes to rustdoc examples.
6a1198d
@YaronWittenstein
Merge branch 'master' into tx-envelope
3624daf
@YaronWittenstein
WIP: Adding Envelope and Context to the Runtime trait.
dda5bfe
@YaronWittenstein
Merge branch 'master' into tx-envelope
a1632a8
@YaronWittenstein
runtime-ffi: adding svm_envelope_alloc and svm_context_alloc.
cf64f23
@YaronWittenstein
runtime-ffi: working on simplifying the API
8dd3ad6
@YaronWittenstein
Runtime - modifying call to receive &mut self instead of &self.
aa3ee01
@YaronWittenstein
Runtime - validate_call doesn't return the target upon success. J…
d8818c3 
…ust returns `Ok(())`.
@YaronWittenstein
Runtime - Using expect instead of unwrap.
d7962d0
@YaronWittenstein
WIP: adaping svm-runtime tests to the new Runtime trait.
ec8498b
@YaronWittenstein
WIP: fixing svm-runtime tests.
9c7f240
@YaronWittenstein
svm-runtime tests pass.
222bc92
@YaronWittenstein
codec: encoding Envelope
17514ff
@YaronWittenstein
runtime-ffi: uncommented tests compile.
53e2352
@YaronWittenstein
cargo fmt
f8a7791
@YaronWittenstein
some cleaning.
e02ca13
@YaronWittenstein
typo
37c6c6f
@YaronWittenstein
runtime-ffi: implemented svm_deploy using the next Message and `C…
308f46f 
…ontext`.
@YaronWittenstein YaronWittenstein marked this pull request as ready for review July 21, 2021 12:53
@YaronWittenstein YaronWittenstein linked an issue Jul 21, 2021 that may be closed by this pull request
C-API changes #253
Closed
neysofu
neysofu suggested changes Jul 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@neysofu neysofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small stuff to change, I've given you details above. Otherwise looks good, awesome so see that we're moving closer to integration.

Comment thread crates/abi/decoder/src/lib.rs Outdated
Comment thread crates/codec/src/context.rs
Comment thread crates/codec/src/context.rs
Comment thread crates/ffi/src/byte_array.rs
Comment thread crates/ffi/src/byte_array.rs
Comment thread crates/runtime/src/runtime/mod.rs
Comment thread crates/types/src/transaction/context.rs
Comment thread crates/types/src/transaction/envelope.rs Outdated
Comment thread crates/types/src/transaction/layer.rs
Comment thread crates/runtime/tests/runtime_tests.rs
@YaronWittenstein YaronWittenstein mentioned this pull request Jul 21, 2021
Closed
@YaronWittenstein YaronWittenstein added go-svm Features required for the go-svm or other clients svm-c-api SVM C API svm-core SVM core change labels Jul 21, 2021
@YaronWittenstein YaronWittenstein merged commit 4bf1ecd into master Jul 22, 2021
@YaronWittenstein YaronWittenstein deleted the tx-envelope branch July 22, 2021 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@neysofu neysofu neysofu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@YaronWittenstein YaronWittenstein

Labels

AA Related to the Accounts Abstraction go-svm Features required for the go-svm or other clients svm svm-c-api SVM C API svm-core SVM core change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AA: Add Context to the API C-API changes AA: Add Envelope to the API

2 participants

@YaronWittenstein @neysofu