Skip to content
This repository has been archived by the owner on Aug 14, 2023. It is now read-only.

Transaction Envelope and Context #311

Merged
merged 31 commits into from
Jul 22, 2021
Merged

Transaction Envelope and Context #311

merged 31 commits into from
Jul 22, 2021

Conversation

YaronWittenstein
Copy link
Contributor

@YaronWittenstein YaronWittenstein commented Jul 20, 2021

This PR attempts to be faithful to the AA Transactions & SVM Integration SMIP.
It's a perquisite for starting the integration with go-svm and later with the go-spacemesh.

Closes #253 #244 #309

Changes

  • Added Envelope and Context to svm-types.
  • Started using the term Message when referring to the binary SVM transaction under svm-runtime and svm-runtime-ffi.
  • Implemented encoding for Envelope and Context under svm-codec.
  • Modified the Runtime trait under svm-runtime to use the Envelope and Context.
  • Simplified creation of In-memory Runtime (doesn't require an injected Key-Value anymore).
  • Adapted the tests of svm-runtime according to the above changes.
  • Modified the runtime-ffi API to adapt to the SMIP as well.
  • Renamed previously missed usages of App into Account.

Future Issues:

@YaronWittenstein YaronWittenstein added this to the July 19 Sprint milestone Jul 20, 2021
This was linked to issues Jul 20, 2021
@YaronWittenstein YaronWittenstein added AA Related to the Accounts Abstraction svm v0.3 labels Jul 20, 2021
@YaronWittenstein YaronWittenstein self-assigned this Jul 20, 2021
@YaronWittenstein YaronWittenstein marked this pull request as ready for review July 21, 2021 12:53
@YaronWittenstein YaronWittenstein linked an issue Jul 21, 2021 that may be closed by this pull request
Copy link
Contributor

@neysofu neysofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small stuff to change, I've given you details above. Otherwise looks good, awesome so see that we're moving closer to integration.

crates/abi/decoder/src/lib.rs Outdated Show resolved Hide resolved
crates/codec/src/context.rs Show resolved Hide resolved
crates/codec/src/context.rs Show resolved Hide resolved
crates/ffi/src/byte_array.rs Show resolved Hide resolved
crates/ffi/src/byte_array.rs Show resolved Hide resolved
crates/runtime/src/runtime/mod.rs Show resolved Hide resolved
crates/types/src/transaction/context.rs Outdated Show resolved Hide resolved
crates/types/src/transaction/envelope.rs Outdated Show resolved Hide resolved
crates/types/src/transaction/layer.rs Show resolved Hide resolved
crates/runtime/tests/runtime_tests.rs Show resolved Hide resolved
@YaronWittenstein YaronWittenstein added go-svm Features required for the go-svm or other clients svm-c-api SVM C API svm-core SVM core change labels Jul 21, 2021
@YaronWittenstein YaronWittenstein merged commit 4bf1ecd into master Jul 22, 2021
@YaronWittenstein YaronWittenstein deleted the tx-envelope branch July 22, 2021 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AA Related to the Accounts Abstraction go-svm Features required for the go-svm or other clients svm svm-c-api SVM C API svm-core SVM core change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AA: Add Context to the API C-API changes AA: Add Envelope to the API
2 participants