Skip to content
This repository has been archived by the owner on Aug 14, 2023. It is now read-only.

AA verify #332

Merged
merged 13 commits into from Aug 16, 2021
Merged

AA verify #332

merged 13 commits into from Aug 16, 2021

Conversation

YaronWittenstein
Copy link
Contributor

@YaronWittenstein YaronWittenstein commented Aug 3, 2021

This PR implements the verify stage as part of the Runtime interface.
More in-depth information about why need that functionality appears in the Account Unification SMIP.

Notes

  • We use the term Verify Data to denote the ABI encoded data given as input for the verify function.
  • We use the term Call Data to denote the ABI encoded data given when running the Transaction function.
  • Since both VerifyData and CallData share the same mechanism, parts of the code simply use the term Input Data.
    In order not to bloat this PR, there are still code parts that use the term Call Data but gradually they will be renamed to use Input Data.
  • Right now the verify returns a CallReceipt. It means that verify can return any blob of data (a.k.a the returndata).
    Whether the verify will return only a boolean is still in research.
  • For now, the verify is expected to work with no access to the Account's storage. In other words, only pure logic
    can take place within verify. See issue: AA: Protected Mode for verify #327

@YaronWittenstein YaronWittenstein self-assigned this Aug 3, 2021
@YaronWittenstein YaronWittenstein linked an issue Aug 3, 2021 that may be closed by this pull request
@YaronWittenstein YaronWittenstein added this to the Aug 2 Sprint milestone Aug 3, 2021
@YaronWittenstein YaronWittenstein added AA Related to the Accounts Abstraction svm v0.3 labels Aug 6, 2021
@YaronWittenstein YaronWittenstein marked this pull request as ready for review August 6, 2021 16:59
Copy link
Contributor

@neysofu neysofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

crates/program/src/lib.rs Outdated Show resolved Hide resolved
@YaronWittenstein YaronWittenstein merged commit 130ae3c into master Aug 16, 2021
@YaronWittenstein YaronWittenstein deleted the AA-verify branch August 16, 2021 10:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AA Related to the Accounts Abstraction svm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AA: verify
2 participants