Skip to content
This repository has been archived by the owner on Aug 14, 2023. It is now read-only.

SVM SDK String #335

Merged
merged 40 commits into from Aug 18, 2021
Merged

SVM SDK String #335

merged 40 commits into from Aug 18, 2021

Conversation

YaronWittenstein
Copy link
Contributor

@YaronWittenstein YaronWittenstein commented Aug 10, 2021

  • The svm_log host function will only expect to receive a blob of bytes. (See issue: Log fields changes #249)
  • Adding a String type to the SVM SDK that will conform to the Fixed-Gas rules.
    Crafted Strings will be used as log entries and behind the scene call the svm_log host function.

@YaronWittenstein YaronWittenstein linked an issue Aug 16, 2021 that may be closed by this pull request
@YaronWittenstein YaronWittenstein added the sdk Related to the SVM SDK label Aug 16, 2021
@YaronWittenstein YaronWittenstein marked this pull request as ready for review August 16, 2021 12:35
crates/sdk/std/Cargo.toml Outdated Show resolved Hide resolved
crates/sdk/std/src/lib.rs Outdated Show resolved Hide resolved
crates/sdk/std/src/option.rs Outdated Show resolved Hide resolved
crates/sdk/std/src/string/builder.rs Outdated Show resolved Hide resolved
crates/sdk/std/src/string/builder.rs Outdated Show resolved Hide resolved
crates/sdk/std/src/string/token.rs Outdated Show resolved Hide resolved
crates/sdk/std/src/string/token.rs Outdated Show resolved Hide resolved
crates/sdk/std/src/string/traits.rs Outdated Show resolved Hide resolved
crates/sdk/std/src/vec.rs Outdated Show resolved Hide resolved
crates/sdk/std/src/string/traits.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@neysofu neysofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We can merge :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
sdk Related to the SVM SDK svm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log fields changes
2 participants