Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: flake8 #144

Merged
merged 3 commits into from
Mar 21, 2018
Merged

TST: flake8 #144

merged 3 commits into from
Mar 21, 2018

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 20, 2018

Same as #141 . See if creating a new one now would make Travis stop ignoring...

@pllim
Copy link
Contributor Author

pllim commented Mar 20, 2018

Nope, adding Python files to the diff doesn't kick of Travis either. 🤷‍♀️

Aha, it is the allowed failure stuff!

@coveralls
Copy link

coveralls commented Mar 20, 2018

Coverage Status

Coverage decreased (-0.08%) to 80.89% when pulling 7f86564 on pllim:flake8-try2 into c1672a5 on spacetelescope:master.

@pllim
Copy link
Contributor Author

pllim commented Mar 20, 2018

Note: You can ignore coveralls. It reports decrease because I deleted some lines w.r.t. master.

@pllim
Copy link
Contributor Author

pllim commented Mar 20, 2018

p.s. As it is, the state of flake8 "violations" are not too bad. But I don't want to fix them all yet to avoid conflicts with my other 2 PRs. It is a matter of a tiny follow-up PR to remove "allowed failures" and clean these up:

gwcs/__init__.py:16:1: E402 module level import not at top of file
gwcs/__init__.py:22:5: F401 '.wcs.*' imported but unused
gwcs/__init__.py:23:5: F401 '.wcstools.*' imported but unused
gwcs/__init__.py:24:5: F401 '.coordinate_frames.*' imported but unused
gwcs/__init__.py:25:5: F401 '.selector.*' imported but unused
gwcs/utils.py:10:1: F401 'astropy.modeling.models.Mapping' imported but unused
gwcs/utils.py:16:1: F401 'astropy.utils.decorators.deprecated' imported but unused
gwcs/utils.py:407:77: E502 the backslash is redundant between brackets
gwcs/utils.py:538:15: F821 undefined name 'is_separable'
gwcs/selector.py:387:9: E741 ambiguous variable name 'l'
gwcs/selector.py:390:9: E741 ambiguous variable name 'l'
gwcs/wcs.py:482:13: E722 do not use bare except'
gwcs/tests/setup_package.py:3:1: E302 expected 2 blank lines, found 1
gwcs/tests/setup_package.py:5:9: F821 undefined name '_ASTROPY_PACKAGE_NAME_'
gwcs/tests/test_region.py:39:1: E266 too many leading '#' for block comment
gwcs/tests/test_region.py:104:36: E128 continuation line under-indented for visual indent
gwcs/tests/test_utils.py:64:24: E128 continuation line under-indented for visual indent
gwcs/tests/test_utils.py:65:23: E124 closing bracket does not match visual indentation
gwcs/tests/test_utils.py:67:24: E128 continuation line under-indented for visual indent
gwcs/tests/test_utils.py:68:23: E124 closing bracket does not match visual indentation
gwcs/tests/test_wcs.py:16:1: F401 '..utils.DimensionalityError' imported but unused
gwcs/tests/test_wcs.py:35:1: E302 expected 2 blank lines, found 1
gwcs/tests/test_wcs.py:297:1: E303 too many blank lines (3)

@nden nden merged commit fac910c into spacetelescope:master Mar 21, 2018
@pllim pllim deleted the flake8-try2 branch March 21, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants