Trying out ipyvuetify #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
reviewed
May 21, 2019
|
@SaOgaz I can't react to a commit message, so have a comment emoji: 💯. |
|
I recommend we merge this into a new branch in the repo, but want to make sure that sounds good to @brechmos-stsci. |
|
If this is a standalone notebook, I don't think it needs to be in a separate branch. |
|
@nmearl there are changes to the cubeviz python class that Craig made. |
|
Mm, good point. I thought you were creating a separate mock up application to demonstrate the usability, but I see you're altering the current version. A separate branch is a good call. |
|
I probably should have done that... I could stick it into a separate file 🤷♀ |
|
This ticket is now being tracked at DATJPP-88 |
|
@brechmos-stsci tested fresh install locally and everything worked. Should be good to merge now. |
|
Works here too. Nice. |
bmorris3
referenced
this pull request
in bmorris3/jdaviz
May 22, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
May 22, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
May 26, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
May 26, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
May 26, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
Jun 13, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
Jun 23, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
Jun 23, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
Jun 23, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
Jul 7, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
Jul 7, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
Jul 7, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
Jul 14, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
Jul 14, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
Jul 19, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
Jul 19, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
Aug 2, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
Aug 4, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
Aug 14, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
Sep 11, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
bmorris3
referenced
this pull request
in bmorris3/jdaviz
Sep 15, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
pllim
referenced
this pull request
in bmorris3/jdaviz
Sep 18, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
rosteen
pushed a commit
to rosteen/jdaviz
that referenced
this pull request
Oct 24, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (spacetelescope#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
kecnry
pushed a commit
to kecnry/jdaviz
that referenced
this pull request
Oct 27, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (spacetelescope#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
kecnry
pushed a commit
to kecnry/jdaviz
that referenced
this pull request
Nov 7, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (spacetelescope#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
kecnry
pushed a commit
to kecnry/jdaviz
that referenced
this pull request
Nov 9, 2023
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (spacetelescope#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
pllim
added a commit
that referenced
this pull request
Jan 23, 2024
#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
gibsongreen
pushed a commit
to gibsongreen/jdaviz
that referenced
this pull request
Feb 12, 2024
spacetelescope#4) * Lim edits * Improve verbiage in docstring Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com> * Address review comments from bmorris3 * Add multi WCS-only test back * Update concept notebook * corrections to the pr to the pr to the pr (spacetelescope#10) * corrections to the pr to the pr to the pr * using app-level attr * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Update jdaviz/configs/imviz/plugins/parsers.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Follow up to PR to my PR to your PR * WCS-only must be loaded into viewer but not visible. Fix concept notebook --------- Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So people can see what i tested out...
note, i was using this pull of ipyvuetify:
ipyvuetify 0.0.1a7
commit 5271541fdeb1c1c4a1de709e7c5dda27075971ba (HEAD -> master, origin/master, origin/HEAD)