From 13dfb7d5530f9bcad1f24e13a757d97b7a1ab387 Mon Sep 17 00:00:00 2001 From: David Law Date: Wed, 15 May 2024 12:25:07 -0400 Subject: [PATCH 1/4] Switch to IRAF starfinder default --- jwst/tweakreg/tweakreg_step.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jwst/tweakreg/tweakreg_step.py b/jwst/tweakreg/tweakreg_step.py index 519a200ab2..b377a93b8f 100644 --- a/jwst/tweakreg/tweakreg_step.py +++ b/jwst/tweakreg/tweakreg_step.py @@ -56,7 +56,7 @@ class TweakRegStep(Step): use_custom_catalogs = boolean(default=False) # Use custom user-provided catalogs? catalog_format = string(default='ecsv') # Catalog output file format catfile = string(default='') # Name of the file with a list of custom user-provided catalogs - starfinder = option('dao', 'iraf', 'segmentation', default='dao') # Star finder to use. + starfinder = option('dao', 'iraf', 'segmentation', default='iraf') # Star finder to use. snr_threshold = float(default=10.0) # SNR threshold above the bkg for star finder # kwargs for DAOStarFinder and IRAFStarFinder, only used if starfinder is 'dao' or 'iraf' kernel_fwhm = float(default=2.5) # Gaussian kernel FWHM in pixels From df4b5091e532a99004fb376eb6130ab77efe9175 Mon Sep 17 00:00:00 2001 From: David Law Date: Wed, 15 May 2024 12:27:17 -0400 Subject: [PATCH 2/4] Add change log entry --- CHANGES.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGES.rst b/CHANGES.rst index 405e502c76..9e7e8950fe 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -152,6 +152,9 @@ tweakreg - Improve error handling in the absolute alignment. [#8450, #8477] +- Change code default to use IRAF StarFinder instead of + DAO StarFinder [#8487] + wfss_contam ----------- From b437afa5bc09be1992b90966e84eb8acff59cc97 Mon Sep 17 00:00:00 2001 From: David Law Date: Wed, 15 May 2024 12:45:48 -0400 Subject: [PATCH 3/4] Change default in docs --- docs/jwst/tweakreg/README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/jwst/tweakreg/README.rst b/docs/jwst/tweakreg/README.rst index 30e39ba0b5..5e707dbbb6 100644 --- a/docs/jwst/tweakreg/README.rst +++ b/docs/jwst/tweakreg/README.rst @@ -218,7 +218,7 @@ The ``tweakreg`` step has the following optional arguments: in pixels. (Default=400) * ``starfinder``: A `str` indicating the source detection algorithm to use. - Allowed values: `'iraf'`, `'dao'`, `'segmentation'`. (Default= `'dao'`) + Allowed values: `'iraf'`, `'dao'`, `'segmentation'`. (Default= `'iraf'`) * ``snr_threshold``: A `float` value indicating SNR threshold above the background. Required for all star finders. (Default=10.0) From f56a21076c01fba6386ef01b0f11f1f4e9c77c75 Mon Sep 17 00:00:00 2001 From: David Law Date: Fri, 17 May 2024 16:50:31 -0400 Subject: [PATCH 4/4] Change to iraf starfinder in tweakreg_catalog default --- jwst/tweakreg/tweakreg_catalog.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jwst/tweakreg/tweakreg_catalog.py b/jwst/tweakreg/tweakreg_catalog.py index fa6835c8b8..bdf9158c14 100644 --- a/jwst/tweakreg/tweakreg_catalog.py +++ b/jwst/tweakreg/tweakreg_catalog.py @@ -148,7 +148,7 @@ def _DaoStarFinderWrapper(data, threshold, mask=None, **kwargs): return sources -def make_tweakreg_catalog(model, snr_threshold, bkg_boxsize=400, starfinder='dao', starfinder_kwargs={}): +def make_tweakreg_catalog(model, snr_threshold, bkg_boxsize=400, starfinder='iraf', starfinder_kwargs={}): """ Create a catalog of point-line sources to be used for image alignment in tweakreg.