Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated stpyfits to replace deprecated function NumCode #36

Merged
merged 1 commit into from May 19, 2017

Conversation

stsci-hack
Copy link
Contributor

This simple update to stpyfits addresses Issue #35 by replacing the call to io.fits.NumCode with the call to the BITPIX2DTYPE dict instead.

Manual testing indicates this resolves the problem identified during pipeline testing. However, this needs to be reviewed by someone familiar with io.fits ( @jhunkeler ?) or someone who uses it for pipeline support ( @mcara ) before being merged into master.

@pllim
Copy link
Contributor

pllim commented May 19, 2017

Something does not look quite right, you did not import BITPIX2DTYPE from within astropy.io.fits.

Note: Also see astropy/astropy#4993

@stsci-hack
Copy link
Contributor Author

This change works due to line 314 where the code uses 'from...import *'. (That was a design decision made years ago... I am just continuing to take advantage of it!).

@pllim
Copy link
Contributor

pllim commented May 19, 2017

In that case, LGTM.

@stsci-hack stsci-hack merged commit 0c1d498 into spacetelescope:master May 19, 2017
@stsci-hack stsci-hack deleted the replace_depr_numcode branch May 19, 2017 19:35
@stsci-hack stsci-hack restored the replace_depr_numcode branch January 24, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants