Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly spell out the contract for read_contextmanager #71

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Explicitly spell out the contract for read_contextmanager #71

merged 1 commit into from
Oct 4, 2018

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Oct 4, 2018

  1. Add documentation.
  2. Add expectation that it should be possible to invoke the context manager multiple times.
  3. Add tests for reentrancy.

Depends on #68, #70

@ttung ttung mentioned this pull request Oct 4, 2018
Merged
@codecov-io
Copy link

codecov-io commented Oct 4, 2018 •
edited
Loading

Codecov Report

Merging #71 into master will increase coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   82.01%   82.59%   +0.58%     
==========================================
  Files          18       18              
  Lines         517      517              
==========================================
+ Hits          424      427       +3     
+ Misses         93       90       -3
Impacted Files Coverage Δ
slicedimage/backends/_base.py 75.86% <ø> (ø) ⬆️
slicedimage/backends/_caching.py 93.47% <0%> (+6.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7397d75...fb34c86. Read the comment docs.

@ttung ttung force-pushed the tonytung-reentrant-contextmanager-base branch from 7018401 to c495b31 Compare October 4, 2018 19:22
@ttung ttung force-pushed the tonytung-reentrant-contextmanager branch from 6cdce2c to 2dcbc22 Compare October 4, 2018 19:22
ambrosejcarr
ambrosejcarr approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@ambrosejcarr ambrosejcarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! This makes so much more sense now. Thanks for adding this. I'm glad my earlier confusion helped 😁

@ttung ttung force-pushed the tonytung-reentrant-contextmanager branch from 2dcbc22 to 816c593 Compare October 4, 2018 22:36
@ttung
Explicitly spell out the contract for read_contextmanager
fb34c86 
1. Add documentation.
2. Add expectation that it should be possible to invoke the context manager multiple times.
3. Add tests for reentrancy.
@ttung ttung changed the base branch from tonytung-reentrant-contextmanager-base to master October 4, 2018 22:39
@ttung ttung force-pushed the tonytung-reentrant-contextmanager branch from 816c593 to fb34c86 Compare October 4, 2018 22:39
@ttung ttung merged commit d07a337 into master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrosejcarr ambrosejcarr ambrosejcarr approved these changes

@shanaxel42 shanaxel42 Awaiting requested review from shanaxel42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttung @codecov-io @ambrosejcarr