New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate docs (plus) #900
Validate docs (plus) #900
Conversation
For discussion: I'd propose that we move to |
2f2335c
to
bd375ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #900 +/- ##
=======================================
Coverage 87.86% 87.86%
=======================================
Files 149 149
Lines 4893 4893
=======================================
Hits 4299 4299
Misses 594 594
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic. See request for clarification in comments, as well as point about literalinclude
s.
|
||
.. toctree:: | ||
usage/index.rst | ||
glossary/glossary.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one would be easy to rewrite in ReST if we wanted to go that route.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was actually surprised that sphinx handled the mix of rst and md so well. I don't feel a particular need to unify on rst (I find markdown easier to author myself) but where we want advanced sphinx features, we'll likely have to convert.
License | ||
======= | ||
|
||
.. literalinclude:: ../../../LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment to others working in the docs -- at some point in the future we should figure out how we want to deal with literalinclude
. Sphinx is careful to restart header levels based on toc
links, but doesn't restart from literalinclude
.
e.g. if you have two files whose contents are:
`file1.rst
Header 1
=========
file2.rst
Header 2
=========
toc link
Header 1
Header 2
literalinclude
Header 1
Header 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But at the moment, you don't see anything that is rendering incorrectly in this PR, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, just pointing out that it's a trap that we'll eventually want to fix.
index.rst
in several cases (see discussion)program-ouputs
for keeping--help
uptodateNote: this doesn't yet include enforcing validation via
STARFISH_VALIDATION_STRICT
. That's waiting on gh-789