Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate docs (plus) #900

Merged
merged 15 commits into from Dec 18, 2018
Merged

Validate docs (plus) #900

merged 15 commits into from Dec 18, 2018

Conversation

joshmoore
Copy link
Member

@joshmoore joshmoore commented Dec 18, 2018

  • schema: add README with file list
  • validation: add examples to module; add usage page
  • misc: update table-of-contents ordering
  • misc: include license file
  • misc: fix codebook and intensity_tables autodocs
  • misc: move to index.rst in several cases (see discussion)
  • sphinx: add program-ouputs for keeping --help uptodate

Note: this doesn't yet include enforcing validation via STARFISH_VALIDATION_STRICT. That's waiting on gh-789

@joshmoore
Copy link
Member Author

For discussion: I'd propose that we move to topic/index.rst as frequently as possible since it produces nice URLs like https://spacetx-starfish.readthedocs.io/en/latest/API/image/ rather than https://spacetx-starfish.readthedocs.io/en/latest/API/image/filtering/filtering.html

@codecov-io
Copy link

codecov-io commented Dec 18, 2018

Codecov Report

Merging #900 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #900   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files         149      149           
  Lines        4893     4893           
=======================================
  Hits         4299     4299           
  Misses        594      594
Impacted Files Coverage Δ
sptx_format/util.py 94.44% <ø> (ø) ⬆️
starfish/pipeline/pipelinecomponent.py 92.68% <ø> (ø) ⬆️
sptx_format/validate_sptx.py 84.74% <ø> (ø) ⬆️
...ish/intensity_table/intensity_table_coordinates.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f6311d...e9679af. Read the comment docs.

Copy link
Member

@ambrosejcarr ambrosejcarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. See request for clarification in comments, as well as point about literalincludes.

docs/source/API/validation/index.rst Outdated Show resolved Hide resolved
docs/source/index.rst Outdated Show resolved Hide resolved

.. toctree::
usage/index.rst
glossary/glossary.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one would be easy to rewrite in ReST if we wanted to go that route.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually surprised that sphinx handled the mix of rst and md so well. I don't feel a particular need to unify on rst (I find markdown easier to author myself) but where we want advanced sphinx features, we'll likely have to convert.

License
=======

.. literalinclude:: ../../../LICENSE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment to others working in the docs -- at some point in the future we should figure out how we want to deal with literalinclude. Sphinx is careful to restart header levels based on toc links, but doesn't restart from literalinclude.

e.g. if you have two files whose contents are:

`file1.rst

Header 1
=========

file2.rst

Header 2
=========

toc link

Header 1
    Header 2

literalinclude

Header 1
Header 2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But at the moment, you don't see anything that is rendering incorrectly in this PR, correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, just pointing out that it's a trap that we'll eventually want to fix.

@joshmoore joshmoore merged commit 5a6790c into spacetx:master Dec 18, 2018
@joshmoore joshmoore deleted the validate-docs branch December 18, 2018 19:31
@joshmoore joshmoore mentioned this pull request Dec 20, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants