517468 - sw-repo-sync: adding option [-l|--list]

[dyordano]

$ spacewalk-repo-sync -l

| Channel Label | Repository |

test_1 | http://test.repo.rh.com/test_1
test_2 | http://test.repo.rh.com/test_2
test_2 | http://test.repo.rh.com/test_client_2
test_3 | No repository set

[sdherr]

Hi dyordano,

This looks like a useful option, but is the bug number correct? This doesn't seem to address the request in https://bugzilla.redhat.com/show_bug.cgi?id=517468 to me.

Also it seems you have a few tabs and some weird indent spacing in getParentsChilds, could you fix that? Also operators like '=', '+=', '+', and '-' always need to be surrounded by spaces for checkstyle reasons, can you fix that too? Thanks.

[dyordano]

Hi Stephen,
Thank you for noticing and sorry for the checkstyle errors. I think they are all fixed now.
This PR is just the first one of several changes that I would like to propose. One of them is exactly what the RFE in the BZ is about.

9b4bc78 517468 - sync all if no channel supplied.
17c04ef 517468 - Adding option [-g|--config]
3df0962 517468 - Adding option [-p|--parent]
b81eeb2 517468 - Adding option [-d|--dry-run]
1f58ef1 517468 - Adding option [-l|--list]

I can open separate RFE BZ for each new option if you think it is necessary.
Regrards.
Dimi

[sdherr]

I don't think that a different RFE for each option is necessary, but
perhaps since 517468 is from a customer we could let that BZ be just about
the option they are requesting and open a second RFE for the other options
you would like to add?

Unless the options only make sense all together and that we should have all
or none of them, in which case we should just add a comment to 517468
describing the new options.

On Thu, Apr 24, 2014 at 8:04 AM, dyordano notifications@github.com wrote:

Hi Stephen,
Thank you for noticing and sorry for the checkstyle errors. I think they
are all fixed now.
This PR is just the first one of several changes that I would like to
propose. One of them is exactly what the RFE in the BZ is about.

9b4bc78 517468 - sync all if no channel supplied.
17c04ef 517468 - Adding option [-g|--config]
3df0962 517468 - Adding option [-p|--parent]
b81eeb2 517468 - Adding option [-d|--dry-run]
1f58ef1 517468 - Adding option [-l|--list]

I can open single RFE BZ for each new option if you think it is necessary.
Regrards.
Dimi

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/41#issuecomment-41271925
.

[dyordano]

I personally prefer that all commits for all new options stay tide to one BZ.
The [-l|--list] option introduces the base code for the rest options, so their is a code dependency between them.

[sdherr]

Okay, please add a comment to the bug then describing the new options and
how they fulfill the original request.

On Thu, Apr 24, 2014 at 9:58 AM, dyordano notifications@github.com wrote:

I personally prefer that all commits for all new options stay tide to one
BZ.
The [-l|--list] option introduces the base code for the rest options, so
their is a code dependency between them.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/41#issuecomment-41282806
.

[dyordano]

Done :)

I would like to add to this RFE two more useful options.

[-l|--list] List the Custom channels available on the Satellite server with the associated repositories.

[-d|--dry-run] Do a test run. No sync takes place. Useful when the repositories are set in the Satellite database and the user want to check the channel->repository configuration beforehand.

[sdherr]

Committing as 5775e76, thanks!