This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
bz1456471 - [RFE] Using own certificates for installer (CA, private key) #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review note: this is covering same area as #274. Anybody who reviews this should review both PRs. |
eherget
suggested changes
Oct 31, 2017
There was a problem hiding this comment.
I found 2 issues with the PR as it currently stands:
- There are print statements near the end of rhn_ssl_tool.py that do not use parenthesis. This caused build failure on Fedora 26. Lines 1156, 1158, 1179, and 1181
- After running a normal install I ran spacewalk-setup again with --skip-db-install and the new --skip-ssl-ca-generation args. When the setup prints "Creating SSL certificates." it then prompts "CA certificate password?". Then it asks for other cert info (cname, org, etc). A few lines later it prints "** SSL: Generating server certificate." This is followed by the prompt "CA password:", however this prompt gets overwritten by the busy spinner, which continues to run. So the issue here is two-fold - why is user prompted two separate times for the CA cert password (or is the second prompt somehow the private key password?), and the busy spinner overwriting the "CA password:" prompt so the user doesn't realize the system is waiting for input.
|
Thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bz1456471 - [RFE] Using own certificates for installer (CA, private key)