Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CCfits package #11262

Merged
merged 3 commits into from May 6, 2019
Merged
Changes from 2 commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -0,0 +1,32 @@
# Copyright 2013-2019 Lawrence Livermore National Security, LLC and other
# Spack Project Developers. See the top-level COPYRIGHT file for details.
#
# SPDX-License-Identifier: (Apache-2.0 OR MIT)

from spack import *


class Ccfits(Package):
"""CCfits is an object oriented interface to the cfitsio library.
It is designed to make the capabilities of cfitsio available to programmers
working in C++. It is written in ANSI C++ and implemented using the C++
Standard Library with namespaces, exception handling, and member template
functions. """

homepage = "https://heasarc.gsfc.nasa.gov/fitsio/CCfits/"
url = "https://heasarc.gsfc.nasa.gov/fitsio/CCfits/CCfits-2.5.tar.gz"

version('2.5', sha256='938ecd25239e65f519b8d2b50702416edc723de5f0a5387cceea8c4004a44740')
version('2.4', sha256='ba6c5012b260adf7633f92581279ea582e331343d8c973981aa7de07242bd7f8')

depends_on('cfitsio')

def url_for_version(self, version):
url = 'https://heasarc.gsfc.nasa.gov/fitsio/CCfits/CCfits-{0}.tar.gz'
return url.format(version)

def install(self, spec, prefix):
print("Install ... ")
This conversation was marked as resolved by grisu48

This comment has been minimized.

Copy link
@scheibelp

scheibelp May 1, 2019

Member

@grisu48

  • This appears to fit the template of a MakefilePackage, if you inherit from that class (rather than Package) you should not need to define an install method at all.
  • Note that spack will generally print a message like "Installing " already.
  • The URL format used by this package is simple enough that it appears that Spack's default URL version substitution should be sufficient

None of these are especially problematic. If you'd like to make edits then I can take another look after. Otherwise let me know and this can be merged now.

This comment has been minimized.

Copy link
@grisu48

grisu48 May 5, 2019

Author Contributor

Thanks for the reply, I will work on the suggestions tomorrow and incorporate them. Just came back from a short holiday.

configure('--prefix={0}'.format(prefix))
make()
make('install')
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.