New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actions: add maintainers as PR reviewers for their packages #12269
Conversation
a2f44a8
to
6916860
Compare
Outstanding question: should we also add a comment that says something like "adding the following package maintainers as reviewers on this PR"? |
Also, I have no idea how to write tests for this. |
Use `spack pkg changed` and `spack maintainers` to figure out which packages changed and who their maintainers are in a PR. Add any maintainers to the PR as reviewers.
6916860
to
cd674e4
Compare
That would be pretty cool, but not absolutely required. We need to start being more aggressive with recommending that people become package |
Ok -- let's merge this, then, and we'll get the initial workflow going.
I think if it actually does something (like this PR does) they'll be more motivated. |
Note that I still need to make a |
btw, could one re-use parts of the following GitHub feature? could also be too cumbersome for our use (e.g. edit in two places). |
@ax3l: did you see my note in the original PR? |
Hm I can’t find the nite. Yes it’s like codeowners but I don’t want people to have to know about the paths to the packages or edit two files — easier if they do it in the And potentially on generated websites and things, whereas codeowners doesn’t. |
This adds a GitHub action that uses
spack pkg changed
andspack maintainers
to figure out which packages changed and who their maintainers are in a PR.Then it adds any maintainers to the PR as reviewers.