From 8a22045042d43bd95d6f0bbbdec39bcd0324ec74 Mon Sep 17 00:00:00 2001 From: Matthew Krafczyk Date: Fri, 6 Jan 2017 22:20:56 -0500 Subject: [PATCH] Add -d and -j options to diy Also add -j to the common arguments --- lib/spack/spack/cmd/common/arguments.py | 6 +++++- lib/spack/spack/cmd/diy.py | 16 +++++++++++++++- lib/spack/spack/cmd/install.py | 4 +--- 3 files changed, 21 insertions(+), 5 deletions(-) diff --git a/lib/spack/spack/cmd/common/arguments.py b/lib/spack/spack/cmd/common/arguments.py index b527c7f1387dc..3f4ab9dd1b435 100644 --- a/lib/spack/spack/cmd/common/arguments.py +++ b/lib/spack/spack/cmd/common/arguments.py @@ -104,4 +104,8 @@ def _specs(self, **kwargs): _arguments['very_long'] = Args( '-L', '--very-long', action='store_true', - help='show full dependency hashes as well as versions') + help='Show full dependency hashes as well as versions.') + +_arguments['jobs'] = Args( + '-j', '--jobs', action='store', type=int, dest="jobs", + help="Explicitly set number of make jobs. Default is #cpus.") diff --git a/lib/spack/spack/cmd/diy.py b/lib/spack/spack/cmd/diy.py index c67e189f7330c..9458f38832f09 100644 --- a/lib/spack/spack/cmd/diy.py +++ b/lib/spack/spack/cmd/diy.py @@ -37,6 +37,10 @@ def setup_parser(subparser): + arguments.add_common_arguments(subparser, ['jobs']) + subparser.add_argument( + '-d', '--source-path', dest='source_path', default=None, + help="Path to the source directory. Defaults to the current directory") subparser.add_argument( '-i', '--ignore-dependencies', action='store_true', dest='ignore_deps', help="don't try to install dependencies of requested packages") @@ -61,6 +65,10 @@ def diy(self, args): if not args.spec: tty.die("spack diy requires a package spec argument.") + if args.jobs is not None: + if args.jobs <= 0: + tty.die("The -j option must be a positive integer!") + specs = spack.cmd.parse_specs(args.spec) if len(specs) > 1: tty.die("spack diy only takes one spec.") @@ -83,13 +91,19 @@ def diy(self, args): tty.msg("Uninstall or try adding a version suffix for this DIY build.") sys.exit(1) + source_path = args.source_path + if source_path is None: + source_path = os.getcwd() + source_path = os.path.abspath(source_path) + # Forces the build to run out of the current directory. - package.stage = DIYStage(os.getcwd()) + package.stage = DIYStage(source_path) # TODO: make this an argument, not a global. spack.do_checksum = False package.do_install( + make_jobs=args.jobs, keep_prefix=args.keep_prefix, install_deps=not args.ignore_deps, verbose=not args.quiet, diff --git a/lib/spack/spack/cmd/install.py b/lib/spack/spack/cmd/install.py index fb01fc2d5e1ac..63b2355295da8 100644 --- a/lib/spack/spack/cmd/install.py +++ b/lib/spack/spack/cmd/install.py @@ -54,9 +54,7 @@ def setup_parser(subparser): alternatively one can decide to install only the package or only the dependencies""" ) - subparser.add_argument( - '-j', '--jobs', action='store', type=int, - help="explicitly set number of make jobs. default is #cpus") + arguments.add_common_arguments(subparser, ['jobs']) subparser.add_argument( '--keep-prefix', action='store_true', dest='keep_prefix', help="don't remove the install prefix if installation fails")