Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

environment.py: write lockfile last #30039

Merged
merged 3 commits into from Apr 19, 2022
Merged

environment.py: write lockfile last #30039

merged 3 commits into from Apr 19, 2022

Conversation

haampie
Copy link
Member

@haampie haampie commented Apr 13, 2022 •
edited

This makes it easier to write spack.lock: spack.yaml type of rules in
Makefiles.

@haampie
environment.py: write lockfile last
aa1ecb3 
This makes it easier to write `spack.lock: spack.yaml` type of rules in
Makfiles.
@tldahlgren
Copy link
Contributor

Is it worth updating the comment to explain the importance of this change? Apparently the existing comment about doing that last was insufficient.

@haampie
Copy link
Member Author

haampie commented Apr 19, 2022

@spackbot run pipeline

@spackbot-app
Copy link

spackbot-app bot commented Apr 19, 2022

I've started that pipeline for you!

@tgamblin tgamblin merged commit abc162c into spack:develop Apr 19, 2022
@haampie haampie deleted the fix/write-lockfile-last branch April 19, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgamblin tgamblin tgamblin approved these changes

Assignees
No one assigned
Labels
environments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haampie @tldahlgren @tgamblin