Merged
Conversation
spackbot-app
bot
added
conflicts
dependencies
extends
maintainers
new-package
new-variant
new-version
labels
tldahlgren
approved these changes
May 3, 2022
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
LGTM. Confirmed sha256.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tamaas is a high-performance C++ library for periodic contact mechanics problems with rough surfaces. I've set up the package so that the Python interface is optionally built (on by default). MPI and OpenMP parallelism is activated if the fftw resolved in the spec has MPI/OpenMP support. I preferred this way of doing things to adding variants for MPI and OpenMP to the package and specifying the fftw dependencies with all the variant combinations.
It is my first time writing a package for Spack, feel free to suggest edits. Cheers!