Skip to content

lammps: added build dependency to py-setuptools#32351

Merged
tldahlgren merged 1 commit intospack:developfrom
prs513rosewood:prs513rosewood/lammps-missing-dep
Aug 25, 2022
Merged

lammps: added build dependency to py-setuptools#32351
tldahlgren merged 1 commit intospack:developfrom
prs513rosewood:prs513rosewood/lammps-missing-dep

Conversation

@prs513rosewood
Copy link
Contributor

LAMMPS' setup.py uses setuptools as of lammps/lammps@2ed8e5cf022. For some reason, installing lammps+python did not report a failed build if setuptools was missing, causing an incomplete install.

Question: when built with python bindings, LAMMPS does not extends("python"), should it?

@spackbot-app
Copy link

spackbot-app bot commented Aug 24, 2022

Hi @prs513rosewood! I noticed that the following package(s) don't yet have maintainers:

  • lammps

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ['prs513rosewood']

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame lammps

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tldahlgren
Copy link
Contributor

tldahlgren commented Aug 25, 2022

Question: when built with python bindings, LAMMPS does not extends("python"), should it?

Depends. There's a rule of thumb given at https://spack.readthedocs.io/en/latest/build_systems/pythonpackage.html?highlight=extends#extends-vs-depends-on.

I'm going to assume if you want to make the change it will be in a different PR.

@tldahlgren tldahlgren merged commit 06ba4d5 into spack:develop Aug 25, 2022
@prs513rosewood prs513rosewood deleted the prs513rosewood/lammps-missing-dep branch August 26, 2022 12:28
ma595 pushed a commit to ma595/spack that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants