Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually 3 fixes. The main fix in this PR beautifies
spack install
output:do_install()
was originally depth-first recursive, and printed<pkg> already installed in ...
multiple times for packages as recursive calls encountered them.spec.traverse(order='post')
to install dependencies instead.We can probably make things cleaner still, but this gets rid of the largest current source of noise in
install()
output.All tasks:
spack install
prints out much less output, especially for large DAGs.deptype_query
argument tospec.traverse()
--fake
installsThe install fix turns 197 lines of
spack install xsdk
output into 152 lines, by getting rid of stuff like this:The new output is much more organized: