Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spoof defense #1

Merged
merged 1 commit into from Aug 24, 2019
Merged

spoof defense #1

merged 1 commit into from Aug 24, 2019

Conversation

@shinyone
Copy link
Collaborator

@shinyone shinyone commented Aug 23, 2019

@eegeeZA
Copy link
Member

@eegeeZA eegeeZA commented Aug 23, 2019

I am also unfamiliar with the Perl syntax. However, since Josh has provided the code in link your referenced, I am sure it will be fine. I just need to check the diff syntax to make sure the code is in the correct place.

@@ -249,6 +249,13 @@ foreach $for (keys %deliveryAddresses) {
(0,'','','',0,0,0,0,0,0,0,'','',0,'',0,());

($mprefix,$mword,$mcount,$musername,$mexpiretime) = ('','','','','');

if ($from && lc($for) eq lc($from)) {

This comment has been minimized.

@eegeeZA

eegeeZA Aug 23, 2019
Member

I have not been able to find docs for the diff syntax, but I believe that 241a244,251 means: near line 241 added lines 244-251. If so, that means the code should be just above # initialize the vars:. But that will not change the final result of the code. My only suggestion would be to indent the body of the if-statement with 4 spaces to align with the rest of the file.

I will merge this pull request soon after I merge the README pull request.

This comment has been minimized.

@shinyone

shinyone Aug 23, 2019
Author Collaborator

the two commits seem to be in the same branch now, this one without the corrections...

@eegeeZA eegeeZA force-pushed the shinyone:master branch from 11a2d60 to a6d2261 Aug 24, 2019
@eegeeZA eegeeZA force-pushed the shinyone:master branch from a6d2261 to 66dba36 Aug 24, 2019
@eegeeZA eegeeZA merged commit cfbd749 into spamgourmet:master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants