Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webhook creation broken by recent changes #186

Closed
dmiddlecamp opened this issue Dec 21, 2015 · 2 comments
Closed

webhook creation broken by recent changes #186

dmiddlecamp opened this issue Dec 21, 2015 · 2 comments

Comments

@dmiddlecamp
Copy link
Contributor

changes between these commits - 8803746...master#diff-dc0cbb44982f142201c58ae6b1c138e5R165

Looks like these changes break the dynamic injection of extra params, breaking many webhooks features. Looks like these didn't get tested.

edit: accidentally some words, updated phrasing to be more clear
@dmiddlecamp dmiddlecamp changed the title webhook creation completely broken by recent untested changes webhook creation broken by recent changes Dec 21, 2015
@dmiddlecamp
Copy link
Contributor Author

should be fixed by 542f81f

@dmiddlecamp
Copy link
Contributor Author

fixed! pending CLI release, but fix available in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmiddlecamp