Navigation Menu

Skip to content
This repository has been archived by the owner on May 12, 2020. It is now read-only.

Ability to set ignored files in settings #33

Closed
suda opened this issue Nov 18, 2014 · 7 comments
Closed

Ability to set ignored files in settings #33

suda opened this issue Nov 18, 2014 · 7 comments
Milestone

Comments

@suda
Copy link
Contributor

suda commented Nov 18, 2014

No description provided.

@suda suda added this to the 0.0.18 milestone Nov 18, 2014
@suda suda closed this as completed in 8daaf02 Nov 20, 2014
@zsup
Copy link

zsup commented Nov 24, 2014

I would recommend that, rather than increasing the list of ignored files, we should have a list of the files which should be included. Off the top of my head, I would expect .ino, .cpp, .c, and .h files, but there may be more. @dmiddlecamp @towynlin @m-mcgowan can you guys lean in here on the correct file list?

Also this behavior should be reflected in www.github.com/spark/spark-cli

@dmiddlecamp
Copy link

I've been going back and forth on that myself, this seems like the better approach, we can always add filetypes later if we discover we missed some. I was going to update the CLI today to have better include/ignore matching using glob, so I can make this change soon.

dmiddlecamp pushed a commit to particle-iot/spark-cli that referenced this issue Nov 24, 2014
@towynlin
Copy link
Contributor

Sure, whitelisting file extensions .ino, .cpp, .c, .h for user files sounds good. That should work for now, and then down the road when people start writing crazy firmware extensions in other languages they'll need an override.

@zsup
Copy link

zsup commented Nov 24, 2014

maybe we also whitelist .o, .a, .bin? things that could get compiled in? I don’t know the types of files we might get

On Monday, Nov 24, 2014 at 2:37 PM, Zachary Crockett notifications@github.com, wrote:

Sure, whitelisting file extensions .ino, .cpp, .c, .h for user files sounds good. That should work for now, and then down the road when people start writing crazy firmware extensions in other languages they'll need an override.

Reply to this email directly or view it on GitHub.

@towynlin
Copy link
Contributor

Hmmm.. sure:

  • .o
  • .a
  • .dll
  • .so
  • .dylib

@seppestas
Copy link

Maybe it's a good idea to make this user configurable somehow. Let every project have a project file similar to a .git-ignore file that defines which files get included and/or which get excluded.
This would also be a great place to define which libraries get included by your project (see #14 and #9).

@suda
Copy link
Contributor Author

suda commented Dec 1, 2014

@Bitbored yeah the #39 would act as .gitignore. Setting in this issue would be global one, which can be overwritten by .ignore/.include files.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants