New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hottake] Let's combine spark-core and spark-extras #1036

Open
RCopeland opened this Issue Jan 11, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@RCopeland
Copy link
Member

RCopeland commented Jan 11, 2019

I don't think dealing with the complexity of having spark-extras components with peer deps on specific versions of spark-core is worth the time saved downloading unneeded components. Since the extras payload is pretty small (and should stay relatively small), I think we should just do away with the separation for both the vanilla and angular implementations.

@yodasw16

This comment has been minimized.

Copy link
Member

yodasw16 commented Jan 11, 2019

I think this makes sense as long as we have a way for a team to exclude parts that they don't need. That's possible with the Sass, but is it possible with JS if people are just using our es5 bundle?

Hot(ter?) take:

What if we strip spark-core down to the essential global styles (basically just fundamentals) instead of "the stuff most sites need to be a 'spark site'" and release everything else independently?

@afebbraro

This comment has been minimized.

Copy link
Member

afebbraro commented Jan 11, 2019

I think having the spark core and spark extras was a way to sort of customize-your-build. I think we can figure out how important we think that is. If its not important then make every just spark and get rid of spark-core and spark-extras. If we think its's really important then I agree with Dave's idea. I will say that from a maintenance perspective, having one package would be a lot easier (just spark).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment