New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links misc #1000

Merged
merged 2 commits into from Jan 2, 2019

Conversation

Projects
None yet
2 participants
@yodasw16
Copy link
Member

yodasw16 commented Jan 2, 2019

What does this PR do?

  • Removed muted link styles and associated variables
  • Changed "Inline Link" to "Base Link" in the docs
  • Updated the class modifier table in Links docs to describe what each class does
  • Updated Cards docs to use .sprk-b-Link--has-icon
  • Update Award docs to use .sprk-b-Link--has-icon
  • Update Footer docs to use .sprk-b-Link--has-icon

Please check off completed items as you work.

If a checklist item or section does not apply to your PR
then please remove it.

Documentation

  • Update Spark Docs Vanilla
  • Update Component Sass Var/Class Modifier table

Code

  • Build Component in Spark Vanilla (Sass, HTML, JS)
  • Unit Testing in Spark Vanilla (100% coverage, 100% passing)

Accessibility

Browser Testing (current version and 1 prior)

  • Google Chrome
  • Google Chrome (Mobile)
  • Mozilla Firefox
  • Mozilla Firefox (Mobile)
  • Microsoft Internet Explorer 11 (only this specific version of IE)
  • Microsoft Edge
  • Apple Safari
  • Apple Safari (Mobile)

Design Review

  • Design reviewed and approved

yodasw16 added some commits Jan 2, 2019

@RCopeland RCopeland merged commit 171ffde into staging Jan 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment