New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add masthead selector mask #1020

Merged
merged 26 commits into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@afebbraro
Copy link
Member

afebbraro commented Jan 7, 2019

What does this PR do?

Add's a mask when the selector dropdown is open. Updates dropdown header padding.

Please check off completed items as you work.

If a checklist item or section does not apply to your PR
then please remove it.

Documentation

  • Update Spark Docs Angular
  • Update Spark Docs Vanilla
  • Update Component Sass Var/Class Modifier table

Code

  • Build Component in Spark Vanilla (Sass, HTML, JS)
  • Build Component in Spark Angular
  • Unit Testing in Spark Vanilla (100% coverage, 100% passing)
  • Unit Testing in Spark Angular (100% coverage, 100% passing)

screen shot 2019-01-10 at 1 08 18 pm

screen shot 2019-01-10 at 11 10 12 am

Accessibility

Browser Testing (current version and 1 prior)

  • Google Chrome (Mobile)
  • Apple Safari (Mobile)
  • Google Chrome
  • Mozilla Firefox
  • Microsoft Internet Explorer 11 (only this specific version of IE)
  • Microsoft Edge
  • Apple Safari

Design Review

  • Design reviewed and approved

Screenshots

Add screenshots to help explain your PR if you'd like. However, this is not
expected.

@afebbraro afebbraro requested review from RCopeland and yodasw16 as code owners Jan 7, 2019

@afebbraro afebbraro force-pushed the afebbraro:masthead-narrow branch from ef34413 to 92758e6 Jan 8, 2019

@RCopeland
Copy link
Member

RCopeland left a comment

couple comments, otherwise lgtm

Show resolved Hide resolved packages/spark-core/tests/masthead.tests.js Outdated
@@ -91,6 +124,8 @@ export class SparkDropdownComponent {
@Input()
title: string;
@Input()
selector: string;

This comment has been minimized.

@RCopeland

RCopeland Jan 10, 2019

Member

I see there's an Input selector and also a value for dropdownType 'mastheadSelector', do we need both?

This comment has been minimized.

@afebbraro

afebbraro Jan 10, 2019

Member

@RCopeland the selector input string is for the masthead selector title. So we need it.

@afebbraro afebbraro force-pushed the afebbraro:masthead-narrow branch from dfa10f2 to 6100a7c Jan 10, 2019

@afebbraro afebbraro force-pushed the afebbraro:masthead-narrow branch from 71341e4 to 5ab7529 Jan 10, 2019

@afebbraro afebbraro merged commit e1ec89d into sparkdesignsystem:staging Jan 10, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment