New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#921 Add New Masthead #993

Merged
merged 33 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@afebbraro
Copy link
Member

afebbraro commented Dec 31, 2018

What does this PR do?

Updates the Masthead structure, presentation and interaction. Issue #921

Please check off completed items as you work.

If a checklist item or section does not apply to your PR
then please remove it.

Documentation

  • Update Spark Docs Vanilla
  • Update Component Sass Var/Class Modifier table
  • Update Spark Docs Angular

Code

  • Build Component in Spark Vanilla (Sass, HTML, JS)
  • Unit Testing in Spark Vanilla (100% coverage, 100% passing)
  • Build Component in Spark Angular
  • Unit Testing in Spark Angular (100% coverage, 100% passing)

Accessibility

Browser Testing (current version and 1 prior)

  • Google Chrome
  • [] Google Chrome (Mobile)
  • Mozilla Firefox (Mobile)
  • Microsoft Internet Explorer 11 (only this specific version of IE)
  • Microsoft Edge
  • Apple Safari
  • Apple Safari (Mobile)

Design Review

  • Design reviewed and approved

@afebbraro afebbraro requested review from RCopeland and yodasw16 as code owners Dec 31, 2018

@afebbraro afebbraro changed the title New Masthead [#921] Add New Masthead Jan 2, 2019

@afebbraro afebbraro changed the title [#921] Add New Masthead #921 Add New Masthead Jan 2, 2019

@afebbraro afebbraro force-pushed the afebbraro:masthead branch 3 times, most recently from ee53ecc to 392e711 Jan 2, 2019

@afebbraro afebbraro force-pushed the afebbraro:masthead branch from e66f8d0 to 3089c53 Jan 3, 2019

@afebbraro afebbraro merged commit 3ef88d5 into sparkdesignsystem:staging Jan 3, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment