Skip to content

Add comments to flow control calls #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Add comments to flow control calls #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9809e3e
Remove old fix
nseidle Mar 10, 2023
3f7adee
Adding comments to flow control calls
nseidle Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Firmware/LoRaSerial/LoRaSerial.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ void setup()

arch.beginWDT(); //Start watchdog timer

updateRTS(true); //Enable serial input
updateRTS(true); //We're ready for more data

systemPrintTimestamp();
systemPrintln("LRS");
Expand Down
7 changes: 5 additions & 2 deletions Firmware/LoRaSerial/Serial.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,10 @@ void serialOutputByte(uint8_t data)
}
}

//Update the output of the RTS pin (host says it's ok to send data when assertRTS = true)
//Update the output of the RTS pin
//LoRaSerial will drive RTS low when it is ready for data
//Given false, we tell the host we *do not* need more data
//Given true, we tell the host we are ready for more data
void updateRTS(bool assertRTS)
{
rtsAsserted = assertRTS;
Expand Down Expand Up @@ -300,7 +303,7 @@ void updateSerial()
//Assert RTS when there is enough space in the receive buffer
if ((!rtsAsserted) && (availableRXBytes() < (sizeof(serialReceiveBuffer) / 2))
&& (availableTXBytes() <= RTS_ON_BYTES))
updateRTS(true);
updateRTS(true); //We're ready for more data

//Attempt to empty the serialTransmitBuffer
outputSerialData(false);
Expand Down
3 changes: 0 additions & 3 deletions Firmware/LoRaSerial/System.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,9 +1100,6 @@ void updateLeds()
{
static uint8_t previousLedUse;

//If training button is being pressed, LEDs are being updated by that function
if (trainBtn != NULL && trainBtn->read()) return;

//When changing patterns, start with the LEDs off
if (previousLedUse != settings.selectLedUse)
{
Expand Down