-
Notifications
You must be signed in to change notification settings - Fork 0
Review #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Review #2
Changes from all commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
3f933d0
toolkit working
lewispg228 78aa81a
cleanup
lewispg228 fbef0a3
should be default on this example to start
lewispg228 ef8e4d0
updating header comments with proper attribution
lewispg228 8902c4e
naming conventions update
lewispg228 2641aeb
remove old commented out I2C writes
lewispg228 80626a8
removed more old commented out I2C writes
lewispg228 5deeb6a
MIT license in all headers
lewispg228 55d616e
all "tabs" are now 4 spaces (except in arduino examples)
lewispg228 0c76127
keywords file lined up
lewispg228 c6a77ff
moved includes into proper location
lewispg228 99fe407
class naming updated
lewispg228 94a8a84
corrected delays and durations in sound effects
lewispg228 c8e7d3f
removed unnecessary calls to off()
lewispg228 985a7fe
utilizing writeRegisterRegion()
lewispg228 27d95f6
removed unnecessary error checking
lewispg228 a60205f
remove whitespace
lewispg228 c3ce97f
removing incorrect comments
lewispg228 514df20
removed sound effect durations
lewispg228 cd10f72
updates and cleanup
lewispg228 f88df61
returning errors on sound effects
lewispg228 008fb4d
update comments for returns on sound effects
lewispg228 a8f0fc7
sound effects const arguments passed by reference
lewispg228 6c198b5
namechange to configureBuzzer
lewispg228 1b8ce22
const arguments for configureBuzzer() and on()
lewispg228 82390f7
individual sound effect functions private
lewispg228 5c7721c
renamed class - removed appended "ArdI2C"
lewispg228 1e46c0c
more description for configureBuzzer()
lewispg228 eace09c
clarifying units as Hz
lewispg228 27f8cfc
lots of little stuff + silent config example
lewispg228 dc776a9
resonant frequency as const
lewispg228 e8e9983
volume options as macros
lewispg228 89bb6e8
library version to v1.0.0
lewispg228 b6e8483
typo
lewispg228 fd5955f
added missing functions to keywords
lewispg228 da16715
moving back to all caps and underscore style for some things
lewispg228 a85cc3b
updating another volume macro
lewispg228 0f35e32
default err on sound effect switch
lewispg228 22de055
comment update to tell duration of 0 = forever
lewispg228 43c6d5b
name change: getAddress to address
lewispg228 ba4b48e
cost argument in begin
lewispg228 fbaac5b
Sound effect descriptions
lewispg228 a62c603
typos and add sound effect descriptions to example header comments
lewispg228 6d293a4
changed how on() and configureBuzzer() work
lewispg228 91b4491
device ID
lewispg228 bd86a3d
Firmware Version read example
lewispg228 65c2dd9
unnecessary "0x0"
lewispg228 45244f0
removing call to off() - handled by durations
lewispg228 e930e26
remove old comment
lewispg228 50182d2
formatting
lewispg228 20bbbf7
header and cpp file in the library are generic c++ files
lewispg228 2c4bff6
spellcheck typos
lewispg228 842fe2f
formatted correctly with clang set to Microsoft
lewispg228 298e207
typo
lewispg228 f6b2980
re-ordering includes to fix compile error
lewispg228 c8e6826
needed stdint.h to properly compile
lewispg228 96afb84
typo
lewispg228 b5141e3
"rest" note is shown as a constant
lewispg228 3d1b942
no longer passing in arguments by reference
lewispg228 c2a18ab
typo
lewispg228 d82df4c
correctly using enum for registers
lewispg228 5346e81
moved to bool status return for example 8
lewispg228 a5ee6d8
moved to bool status return for example 9
lewispg228 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.