Example 3 Patch #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on, fixed incorrect delay causing sensor to not read, added clarifying comments, tested for function
|
I can also add the oscilloscope capture png to the project folder in a second commit, if that would be helpful for users. |
|
@gigapod Any reason why this hasn't been merged yet? |
|
HI @xp-dv - Thanks for the PR! While I did update this library by migrating to the SparkFun Toolkit, updating the repo layout and adding Doxygen support, I don't monitor this repo - so I didn't see this PR. That said, I'll take a look and review the PR. Looks like the original implementation could use some tweaks and cleanup. NOTE: Once the code looks good, we'll still need to validate operation before merging. This can take up to a month right now. -Kirk |
gigapod
reviewed
Sep 29, 2025
| const float speedOfSound = 340.00; // Speed of sound in m/s | ||
| const float millisPerSecond= 1000.00; // Number of milliseconds in a second | ||
|
|
||
| void setup() { |
There was a problem hiding this comment.
- Agree we can simplify the constant to eliminate the calculation in the loop. But the math behind this should be in the comments. I'd also rename the const to include units
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example 3 Patch: