Skip to content

Hide web config configurePPP on non-LG290P platforms #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

Hide web config configurePPP on non-LG290P platforms #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions Firmware/RTK_Everywhere/AP-Config/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,16 +362,18 @@
<span class="icon-info-circle text-primary ms-2"></span>
</span>
</div>
<div class="form-group row">
<label for="configurePPP" class="box-margin20 col-sm-3 col-5 col-form-label">Configure PPP:
<span class="tt" data-bs-placement="right"
title="The configuration string for PPP. Enter values separated by spaces, not commas. Default: 2 1 120 0.10 0.15">
<span class="icon-info-circle text-primary ms-2"></span>
</span>
</label>
<div class="col-sm-8 col-6">
<input type="text" class="form-control" id="configurePPP">
<p id="configurePPPError" class="inlineError"></p>
<div id="configurePppSetting">
<div class="form-group row">
<label for="configurePPP" class="box-margin20 col-sm-3 col-5 col-form-label">Configure PPP:
<span class="tt" data-bs-placement="right"
title="The configuration string for PPP. Enter values separated by spaces, not commas. Default: 2 1 120 0.10 0.15">
<span class="icon-info-circle text-primary ms-2"></span>
</span>
</label>
<div class="col-sm-8 col-6">
<input type="text" class="form-control" id="configurePPP">
<p id="configurePPPError" class="inlineError"></p>
</div>
</div>
</div>
</div>
Expand Down
20 changes: 19 additions & 1 deletion Firmware/RTK_Everywhere/AP-Config/src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,9 @@ function parseIncoming(msg) {
hide("constellationSbas"); //Not supported on UM980
hide("constellationNavic"); //Not supported on UM980

show("galileoHasSetting");
hide("lg290pGnssSettings");

show("measurementRateInput");

show("loraConfig");
Expand Down Expand Up @@ -711,6 +714,7 @@ function parseIncoming(msg) {
ge("enableARPLogging").dispatchEvent(new CustomEvent('change'));
ge("enableAutoFirmwareUpdate").dispatchEvent(new CustomEvent('change'));
ge("enableAutoReset").dispatchEvent(new CustomEvent('change'));
ge("enableGalileoHas").dispatchEvent(new CustomEvent('change'));

updateECEFList();
updateGeodeticList();
Expand Down Expand Up @@ -876,7 +880,7 @@ function validateFields() {
if (isElementShown("lg290pGnssSettings") == true) {
checkElementValue("rtcmMinElev", -90, 90, "Must be between -90 and 90", "collapseGNSSConfig");
}
if (ge("enableGalileoHas").checked == true) {
if (isElementShown("configurePppSetting") == true) {
checkElementStringSpacesNoCommas("configurePPP", 1, 30, "Must be 1 to 30 characters. Separated by spaces. Commas not allowed", "collapseGNSSConfig");
}
if (ge("enableNtripClient").checked == true) {
Expand Down Expand Up @@ -2006,6 +2010,20 @@ document.addEventListener("DOMContentLoaded", (event) => {
adjustHAE();
});

ge("enableGalileoHas").addEventListener("change", function () {
if ((isElementShown("galileoHasSetting") == true) && (isElementShown("lg290pGnssSettings") == true)) {
if (ge("enableGalileoHas").checked == true) {
show("configurePppSetting");
}
else {
hide("configurePppSetting");
}
}
else {
hide("configurePppSetting"); // Hide on Torch UM980 - i.e. non-LG290P
}
});

for (let y = 0; y < numCorrectionsSources; y++) {
var buttonName = "corrPrioButton" + y;
ge(buttonName).addEventListener("click", function () {
Expand Down