Add BLE Support #238
Merged
Add BLE Support #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burnsed
force-pushed
the
release_candidate
branch
from
9e111d2 to
7298fd0
Compare
Author
|
FYI, I got about 7hrs of continuous use/testing done over 2 days. Everything worked well. @nseidle I think the change is ready. |
Member
|
Hi @burnsed - I keep trying to merge this but am having problems resolving the conflicts. My apologies for the delay! If you have the chance to re-base, I promise I won't ask again. If not, I understand, and I'll force it. |
burnsed
force-pushed
the
release_candidate
branch
from
0227032 to
b1841c7
Compare
burnsed
force-pushed
the
release_candidate
branch
from
b1841c7 to
95e26ef
Compare
Author
|
@nseidle ok, should be good to go. I did a quick sanity test to make sure the BLE changes still work with everything new. |
Member
|
Many thanks! We'll get this into the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR #235 for the original description and change.
Note: I'd like to test this change a bit more after issue #237 is resolved. I'm not 100% sure that bug is only adding noise. It might also be mangling some of the GNSS messages as well.
@nseidle I think I addressed your first to points. For the 3rd (bluetoothSerial library moving to its own repo soon), is there anything you'd like me to do as part of this change for that? I think it should be pretty easy to split the two bluetooth serial libraries into external dependencies once you're ready.
Thanks!