Skip to content

Fix Angle Calculations #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Fix Angle Calculations #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ceb82f
Fix Angle Calculations
santaimpersonator Sep 1, 2023
22e1f92
Changed "deg" to degree symbol in example printing
MadisonC-SparkFun Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/Example3_AngleCalculations/Example3_AngleCalculations.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ void loop()
float angleCalculation = sensor.getAngleResult();

Serial.print("XYX: ");
Serial.print(angleCalculation);
Serial.println(" mT");
Serial.print(angleCalculation, 4);
Serial.println("°");

}
else
Expand Down
8 changes: 4 additions & 4 deletions src/SparkFun_TMAG5273_Arduino_Library.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2644,10 +2644,10 @@ float TMAG5273::getZData()
/// @return Angle measurement result in degrees (float value)
float TMAG5273::getAngleResult()
{
int8_t angleLSB = 0;
int8_t angleMSB = 0;
uint8_t angleLSB = 0;
uint8_t angleMSB = 0;

angleLSB = readRegister(TMAG5273_REG_ANGLE_RESULT_LSB);
angleLSB = readRegister(TMAG5273_REG_ANGLE_RESULT_LSB) & 0b11111111;
angleMSB = readRegister(TMAG5273_REG_ANGLE_RESULT_MSB);

// Variable to hold the full angle MSB and LSB registers
Expand All @@ -2663,7 +2663,7 @@ float TMAG5273::getAngleResult()
angleReg = (angleMSB << 8) | angleLSB;

// Removing the uneeded bits for the fraction value
decValue = (angleReg && (0b0000000000001111)) / 16;
decValue = float(angleLSB & 0b1111) / 16;

// Shift off the decimal value (last 4 bits)
angleVal = angleReg >> 4;
Expand Down