Change to template structure #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Audio class (and other feature sets) now uses templating instead of virtual inheritance
gigapod
reviewed
Nov 29, 2023
Member
gigapod
left a comment
gigapod
left a comment
There was a problem hiding this comment.
Overall looks awesome - glad it's working.
And solid - fast - hacking at this!
Member
|
One other comment I had here - for the internal classes/templates, can we move to a CamelCase class name, not the YELLING_AT_YOU format? Minor, but more approachable and modern. |
Closed
Collaborator
Author
Agreed, will fix the code style once the architecture is finalized, was just picking some names to be able to move forward. Tracking this in #9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PaulZC This is the new structure that @gigapod and I discussed. This will allow us to separate features that are supported on different modules, such as audio and GNSS, more easily and portably than virtual inheritance. I've only done the audio so far, but I tested this with the LARA-R6 nd it works fine. If all looks good, I'll work on doing the same with other features (mainly just pulling them out of the base class).